[GitHub] piiswrong commented on a change in pull request #9184: 1 d conv with cudnn

[GitBox <gi...@apache.org>]

piiswrong commented on a change in pull request #9184: 1 d conv with cudnn
URL: https://github.com/apache/incubator-mxnet/pull/9184#discussion_r158862355
 
 

 ##########
 File path: src/operator/nn/convolution-inl.h
 ##########
 @@ -67,13 +67,13 @@ struct ConvolutionParam : public dmlc::Parameter<ConvolutionParam> {
   bool cudnn_off;
   dmlc::optional<int> layout;
   DMLC_DECLARE_PARAMETER(ConvolutionParam) {
-    DMLC_DECLARE_FIELD(kernel).describe("Convolution kernel size: (h, w) or (d, h, w)");
+    DMLC_DECLARE_FIELD(kernel).describe("Convolution kernel size: (h), (h, w) or (d, h, w)");
     DMLC_DECLARE_FIELD(stride).set_default(TShape())
-    .describe("Convolution stride: (h, w) or (d, h, w). Defaults to 1 for each dimension.");
+    .describe("Convolution stride: (h), (h, w) or (d, h, w). Defaults to 1 for each dimension.");
 
 Review comment:
   (h) -> (w,)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services