You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/06/19 17:49:12 UTC
[GitHub] [couchdb-documentation] bessbd opened a new pull request #561: Allow drilldown for search to always be specified as list of lists
bessbd opened a new pull request #561:
URL: https://github.com/apache/couchdb-documentation/pull/561
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
<!-- Please give a short brief for the pull request,
what problem it solves or how it makes things better. -->
To use multiple `drilldown` parameters users had to define
`drilldown` multiple times to be able supply them.
This caused interoperability issues as most languages require
defining query parameters and request bodies as associative
arrays, maps or dictionaries where the keys are unique.
This change enables defining `drilldown` as a list of lists so
that other languages can define multiple drilldown keys and values.
## Testing recommendations
<!-- Describe how we can test your changes.
Does it provides any behaviour that the end users
could notice? -->
`make check` passed for me locally
## GitHub issue number
<!-- If this is a significant change, please file a separate issue at:
https://github.com/apache/couchdb-documentation/issues
and include the number here and in commit message(s) using
syntax like "Fixes #472" or "Fixes apache/couchdb#472". -->
## Related Pull Requests
<!-- If your changes affects multiple components in different
repositories please put links to those pull requests here. -->
This is related to https://github.com/apache/couchdb/pull/2958
## Checklist
- [ ] Update [rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script) with the commit hash once this PR is rebased and merged
<!-- Before opening the PR, consider running `make check` locally for a faster turnaround time -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-documentation] rnewson merged pull request #561: Allow drilldown for search to always be specified as list of lists
Posted by GitBox <gi...@apache.org>.
rnewson merged pull request #561:
URL: https://github.com/apache/couchdb-documentation/pull/561
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-documentation] bessbd commented on pull request #561: Allow drilldown for search to always be specified as list of lists
Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #561:
URL: https://github.com/apache/couchdb-documentation/pull/561#issuecomment-648744883
Thank you for the review and the merge, @rnewson !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-documentation] rnewson commented on a change in pull request #561: Allow drilldown for search to always be specified as list of lists
Posted by GitBox <gi...@apache.org>.
rnewson commented on a change in pull request #561:
URL: https://github.com/apache/couchdb-documentation/pull/561#discussion_r444056592
##########
File path: src/ddocs/search.rst
##########
@@ -814,7 +814,7 @@ Drilldown
You can restrict results to documents with a dimension equal to the specified label.
Restrict the results by adding ``drilldown=["dimension","label"]`` to a search query. You
can include multiple ``drilldown`` parameters to restrict results along multiple
-dimensions.
+dimensions: ``drilldown=[["dimension1","label1"], ["dimension2","label2"]]``
Review comment:
can you show an example of multiple parameters (like the sentence before indicates is allowed) and then clarify that this new example allows you to do this with a single drilldown parameter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-documentation] bessbd commented on a change in pull request #561: Allow drilldown for search to always be specified as list of lists
Posted by GitBox <gi...@apache.org>.
bessbd commented on a change in pull request #561:
URL: https://github.com/apache/couchdb-documentation/pull/561#discussion_r444069816
##########
File path: src/ddocs/search.rst
##########
@@ -814,7 +814,7 @@ Drilldown
You can restrict results to documents with a dimension equal to the specified label.
Restrict the results by adding ``drilldown=["dimension","label"]`` to a search query. You
can include multiple ``drilldown`` parameters to restrict results along multiple
-dimensions.
+dimensions: ``drilldown=[["dimension1","label1"], ["dimension2","label2"]]``
Review comment:
Done in 5c02705 . Let me know what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org