[jira] [Commented] (HDFS-7681) Fix ReplicaInputStream constructor to take InputStreams

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-7681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294162#comment-14294162 ] 

Hadoop QA commented on HDFS-7681:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12694807/HDFS-7681.patch
  against trunk revision f56da3c.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.balancer.TestBalancer

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9346//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9346//console

This message is automatically generated.

> Fix ReplicaInputStream constructor to take InputStreams
> -------------------------------------------------------
>
>                 Key: HDFS-7681
>                 URL: https://issues.apache.org/jira/browse/HDFS-7681
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>    Affects Versions: 3.0.0
>            Reporter: Joe Pallas
>            Assignee: Joe Pallas
>         Attachments: HDFS-7681.patch
>
>
> As noted in HDFS-5194, the constructor for {{ReplicaInputStream}} takes {{FileDescriptor}} s that are immediately turned into {{InputStream}} s, while the callers already have {{FileInputStream}} s from which they extract {{FileDescriptor}} s.  This seems to have been done as part of a large set of changes to appease findbugs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)