[GitHub] [arrow-datafusion] alamb commented on pull request #4156: Full support for time32 and time64 literal values (`ScalarValue`)

[GitBox <gi...@apache.org>]

alamb commented on PR #4156:
URL: https://github.com/apache/arrow-datafusion/pull/4156#issuecomment-1315470038

   > out of bound value make the casting crash, i think it's worth fixing as well. Perhaps another follow on issue/pr to fix
   
   FWIW I reran those examples from @waitingkuo  using datafusion-cli on this branch and they no longer panics (not sure if it is this PR or something else). 
   
   ```
   cd datafusion-cli
   cargo run datafusion-cli
   ...
   
   DataFusion CLI v14.0.0
   ❯ select 86400000000000::time;
   +-----------------------+
   | Int64(86400000000000) |
   +-----------------------+
   | ERROR CONVERTING DATE |
   +-----------------------+
   1 row in set. Query took 0.041 seconds.
   
   ❯ select (-1)::time;
   +-----------------------+
   | Int64(-1)             |
   +-----------------------+
   | ERROR CONVERTING DATE |
   +-----------------------+
   1 row in set. Query took 0.002 seconds.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org