You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "snazy (via GitHub)" <gi...@apache.org> on 2024/11/26 11:19:41 UTC

[PR] Replace Jetbrains with Jakarta annotations [polaris]

snazy opened a new pull request, #482:
URL: https://github.com/apache/polaris/pull/482

   `org.jetbrains.annotations.NotNull`/`Nullable` -> `jakarta.annotations.Nonnull`/`Nullable` plus Guava's `VisibleForTesting`
   
   The Jakarta annotations are likely better supported by validation frameworks like Hibernate Validator.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Replace Jetbrains with Jakarta annotations [polaris]

Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #482:
URL: https://github.com/apache/polaris/pull/482#issuecomment-2500552094

   > NB: it's already done on Quarkus pr
   
   Correct. That's where it's from - to reduce the amount of changes from that PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Replace Jetbrains with Jakarta annotations [polaris]

Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on code in PR #482:
URL: https://github.com/apache/polaris/pull/482#discussion_r1860352995


##########
extension/persistence/eclipselink/build.gradle.kts:
##########
@@ -45,7 +45,7 @@ dependencies {
     }
   }
 
-  compileOnly(libs.jetbrains.annotations)
+  compileOnly(libs.jakarta.annotation.api)

Review Comment:
   Or will the build changes make it impossible to accidentally use the wrong annotation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Replace Jetbrains with Jakarta annotations [polaris]

Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on PR #482:
URL: https://github.com/apache/polaris/pull/482#issuecomment-2503427264

   LGTM; but can we add this to the linter? I would hate to see us accidentally regress back to the wrong ones.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Replace Jetbrains with Jakarta annotations [polaris]

Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy merged PR #482:
URL: https://github.com/apache/polaris/pull/482


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Replace Jetbrains with Jakarta annotations [polaris]

Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #482:
URL: https://github.com/apache/polaris/pull/482#issuecomment-2500468252

   NB: it's already done on Quarkus pr 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Replace Jetbrains with Jakarta annotations [polaris]

Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #482:
URL: https://github.com/apache/polaris/pull/482#issuecomment-2500572097

   Love it 😀 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Replace Jetbrains with Jakarta annotations [polaris]

Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on code in PR #482:
URL: https://github.com/apache/polaris/pull/482#discussion_r1861673509


##########
extension/persistence/eclipselink/build.gradle.kts:
##########
@@ -45,7 +45,7 @@ dependencies {
     }
   }
 
-  compileOnly(libs.jetbrains.annotations)
+  compileOnly(libs.jakarta.annotation.api)

Review Comment:
   Yes, this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org