You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/21 08:28:13 UTC

[GitHub] [camel] essobedo opened a new pull request, #8737: CAMEL-18730: camel-report-maven-plugin - Fix import issue

essobedo opened a new pull request, #8737:
URL: https://github.com/apache/camel/pull/8737

   Backport of https://issues.apache.org/jira/browse/CAMEL-18730 for 3.18
   
   ## Motivation
   
   After generating the route coverage of the tests, if we launch the maven command `mvn camel-report:route-coverage`, the plugin fails due to an import issue.
   
   ## Modifications:
   
   * Remove the bad import and replace it with `List.of`.
   
   ## Result
   
   Tested against the example `main`:
   
   ```
   $ mvn camel-report:route-coverage
   [INFO] Scanning for projects...
   [INFO] 
   [INFO] ------------< org.apache.camel.example:camel-example-main >-------------
   [INFO] Building Camel :: Example :: Main 3.20.0-SNAPSHOT
   [INFO] --------------------------------[ jar ]---------------------------------
   [INFO] 
   [INFO] --- camel-report-maven-plugin:3.20.0-SNAPSHOT:route-coverage (default-cli) @ camel-example-main ---
   [INFO] Discovered 1 routes
   [INFO] Route coverage summary:
   
   Class:	org.apache.camel.example.MyRouteBuilder
   Route:	foo
   
     Line #       Count    Route
     ------       -----    -----
         25           2    from
         26           2      bean
         27           2      log
   
   Coverage: 3 out of 3 (100.0% / threshold 100.0%)
   Status: Success
   
   
   [INFO] 
   [INFO] Overall coverage summary:
   
   Coverage: 3 out of 3 (100.0% / threshold 0.0%)
   Status: Success
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] essobedo commented on pull request #8737: CAMEL-18730: camel-report-maven-plugin - Fix import issue

Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #8737:
URL: https://github.com/apache/camel/pull/8737#issuecomment-1321784240

   The checkstyle issue is not related to this change:
   ```
   ...
   [ERROR] /home/runner/work/camel/camel/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Run.java:282:5: Method run length is 256 lines (max allowed is 250). [MethodLength]
   Audit done.
   ...
   [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:checkstyle (default-cli) on project camel-jbang-core: An error has occurred in Checkstyle report generation. Failed during checkstyle execution: There is 1 error reported by Checkstyle 8.45.1 with camel-checkstyle.xml ruleset. -> [Help 1]
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] essobedo merged pull request #8737: CAMEL-18730: camel-report-maven-plugin - Fix import issue

Posted by GitBox <gi...@apache.org>.
essobedo merged PR #8737:
URL: https://github.com/apache/camel/pull/8737


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #8737: CAMEL-18730: camel-report-maven-plugin - Fix import issue

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8737:
URL: https://github.com/apache/camel/pull/8737#issuecomment-1321776973

   :no_entry_sign: There are (likely) no components to be tested in this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org