You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2023/01/20 06:37:53 UTC
[GitHub] [hudi] SteNicholas opened a new pull request, #7716: [HUDI-5558] Serializable interface implementation don't explicitly declare serialVersionUID
SteNicholas opened a new pull request, #7716:
URL: https://github.com/apache/hudi/pull/7716
### Change Logs
`Serializable` interface implementation don't explicitly declare `serialVersionUID`, which causes the `InvalidClassException` for the deserialization. `Serializable` interface implementation should explicitly declare serialVersionUID for all the implementation including their subclass implementation.
### Impact
Operators and functions of hudi-flink module explicitly declare `serialVersionUID`.
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [x] Change Logs and Impact were stated clearly
- [x] Adequate tests were added if applicable
- [x] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] SteNicholas closed pull request #7716: [HUDI-5558] Serializable interface implementation don't explicitly declare serialVersionUID
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #7716: [HUDI-5558] Serializable interface implementation don't explicitly declare serialVersionUID
URL: https://github.com/apache/hudi/pull/7716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] SteNicholas commented on pull request #7716: [HUDI-5558] Serializable interface implementation don't explicitly declare serialVersionUID
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #7716:
URL: https://github.com/apache/hudi/pull/7716#issuecomment-1408035488
@alexeykudinkin, the `serialVersionUID` should only be set to 1 because different JVM generates different `serialVersionUID` and the compatibility problem of `serialVersionUID` is inevitable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on pull request #7716: [HUDI-5558] Serializable interface implementation don't explicitly declare serialVersionUID
Posted by "alexeykudinkin (via GitHub)" <gi...@apache.org>.
alexeykudinkin commented on PR #7716:
URL: https://github.com/apache/hudi/pull/7716#issuecomment-1409047425
> the serialVersionUID should only be set to 1 because different JVM generates different serialVersionUID and the compatibility problem of serialVersionUID is inevitable. WDYT?
Clarification, it might be generated differently by different JVM versions but this process is deterministic and is dependent on the class in question.
Can you elaborate on the problem you're trying to address here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] SteNicholas commented on pull request #7716: [HUDI-5558] Serializable interface implementation don't explicitly declare serialVersionUID
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on PR #7716:
URL: https://github.com/apache/hudi/pull/7716#issuecomment-1398542077
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7716: [HUDI-5558] Serializable interface implementation don't explicitly declare serialVersionUID
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7716:
URL: https://github.com/apache/hudi/pull/7716#issuecomment-1398012661
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "860cf0ff1a05c3e79ccc57c48efa44894a916c4f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14492",
"triggerID" : "860cf0ff1a05c3e79ccc57c48efa44894a916c4f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 860cf0ff1a05c3e79ccc57c48efa44894a916c4f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14492)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7716: [HUDI-5558] Serializable interface implementation don't explicitly declare serialVersionUID
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7716:
URL: https://github.com/apache/hudi/pull/7716#issuecomment-1398007450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "860cf0ff1a05c3e79ccc57c48efa44894a916c4f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "860cf0ff1a05c3e79ccc57c48efa44894a916c4f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 860cf0ff1a05c3e79ccc57c48efa44894a916c4f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] SteNicholas commented on pull request #7716: [HUDI-5558] Serializable interface implementation don't explicitly declare serialVersionUID
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #7716:
URL: https://github.com/apache/hudi/pull/7716#issuecomment-1409669377
@alexeykudinkin, the problem is that a Flink job which writes data to Hudi and enables async clustering runs on the kubernetes with different JVM，then the job throws the `InvalidClassException` for the deserialization. The reason of the exception is that `Serializable` interface implementation don't explicitly declare `serialVersionUID`. Therefore, I introduces the `serialVersionUID` for the operators and functions of hudi-flink module. This changes have been discussed with @danny0405 offline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7716: [HUDI-5558] Serializable interface implementation don't explicitly declare serialVersionUID
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7716:
URL: https://github.com/apache/hudi/pull/7716#issuecomment-1398267238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "860cf0ff1a05c3e79ccc57c48efa44894a916c4f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14492",
"triggerID" : "860cf0ff1a05c3e79ccc57c48efa44894a916c4f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 860cf0ff1a05c3e79ccc57c48efa44894a916c4f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14492)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7716: [HUDI-5558] Serializable interface implementation don't explicitly declare serialVersionUID
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7716:
URL: https://github.com/apache/hudi/pull/7716#issuecomment-1398807567
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "860cf0ff1a05c3e79ccc57c48efa44894a916c4f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14492",
"triggerID" : "860cf0ff1a05c3e79ccc57c48efa44894a916c4f",
"triggerType" : "PUSH"
}, {
"hash" : "860cf0ff1a05c3e79ccc57c48efa44894a916c4f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14498",
"triggerID" : "1398542077",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 860cf0ff1a05c3e79ccc57c48efa44894a916c4f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14492) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14498)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7716: [HUDI-5558] Serializable interface implementation don't explicitly declare serialVersionUID
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7716:
URL: https://github.com/apache/hudi/pull/7716#issuecomment-1398597214
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "860cf0ff1a05c3e79ccc57c48efa44894a916c4f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14492",
"triggerID" : "860cf0ff1a05c3e79ccc57c48efa44894a916c4f",
"triggerType" : "PUSH"
}, {
"hash" : "860cf0ff1a05c3e79ccc57c48efa44894a916c4f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14498",
"triggerID" : "1398542077",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 860cf0ff1a05c3e79ccc57c48efa44894a916c4f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14492) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14498)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] SteNicholas commented on pull request #7716: [HUDI-5558] Serializable interface implementation don't explicitly declare serialVersionUID
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on PR #7716:
URL: https://github.com/apache/hudi/pull/7716#issuecomment-1398017208
@danny0405, this pull request explicitly declares the `serialVersionUID` for hudi-flink module. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org