You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Carl Karsten <ca...@personnelware.com> on 2005/10/18 13:40:52 UTC

failed commit not totaly rolled back

C:\vfe\dev\WinPars>svn commit -m "flowchart"
Sending        DATA\ErrorLog.FPT
Sending        DATA\ErrorLog.dbf
Sending        LIBS\BILLPAY.VCT
Sending        LIBS\billpay.vcx
Sending        METADATA\METADATA.DBF
Sending        METADATA\VfeMeta.DBF
Adding         doc
Adding  (bin)  doc\bp.odg
Transmitting file data ..svn: Commit failed (details follow):
svn: Error processing command 'committed' in 'C:\vfe\dev\WinPars\DATA'
svn: Error replacing text-base of 'ErrorLog.FPT'
svn: Can't copy 'C:\vfe\dev\WinPars\DATA\.svn\tmp\text-base\ErrorLog.FPT.svn-base' 
to 'C:\vfe\dev\WinPars\DATA\.svn\tmp\ErrorLog.FPT.tmp.tmp': There is not enough 
space on the disk.

So I dump the 130mb of /temp files and try again.

C:\vfe\dev\WinPars>svn commit -m "flowchart"
Sending        DATA\ErrorLog.FPT
Sending        DATA\ErrorLog.dbf
Sending        LIBS\BILLPAY.VCT
Sending        LIBS\billpay.vcx
Sending        METADATA\METADATA.DBF
Sending        METADATA\VfeMeta.DBF
Adding         doc
Adding  (bin)  doc\bp.odg
Transmitting file data ..svn: Commit failed (details follow):
svn: Out of date: 'DATA/ErrorLog.FPT' in transaction '16-1'


It seems when the first attemt failed it didn't completely roll back everything it 
had started, which I am guessing is a bug?

^Carl Karsten

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: failed commit not totaly rolled back

Posted by Nicolás Lichtmaier <ni...@reloco.com.ar>.
>>Why is there "post-commit processing" ?  shouldn't all processing be part of the
>>transaction such that if any parts fail, the whole thing gets rolled back?
>>    
>>
>Because after the commit has succeded in the repository, the working copy
>must be updated to reflect the actual revisions stored there. That's not
>part of the server transaction
>  
>

Because of this, the server should never respond with an error if the 
transaction was commited!

This happened to me some weeks ago: It was a very large commit, I went 
to the fsfs transaction directory to see it "live" while it was being 
built =). The commit was succesful, but subversion failed to delete the 
txn directory (as I was standing in that dir with a shell). The client 
received an error, and the WC was left broken. IMO these "cleanup 
errors" should be logged in the server, but the operation must still be 
reported as succesful to the client...!


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: failed commit not totaly rolled back

Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Tue, 18 Oct 2005, Carl Karsten wrote:

> Joseph Galbraith wrote:
> > Philip Martin wrote:
> >
> >>> Adding         doc
> >>> Adding  (bin)  doc\bp.odg
> >>> Transmitting file data ..svn: Commit failed (details follow):
> >>> svn: Out of date: 'DATA/ErrorLog.FPT' in transaction '16-1'
> >>>
> >>> It seems when the first attemt failed it didn't completely roll back
> >>> everything it had started, which I am guessing is a bug?
> >>
> >>
> >> No.  The first commit failed during post-commit processing of the
> >> working copy, that's after the commit completed in the repository.
> >> The failure means the working copy is out-of-date compared to the
> >> repository, so the second commit fails.
> >
> >
> > Definitely an error message that is a little confusing though...
> > maybe it could be tweaked a bit to say that the commit succeeded,
> > but the working copy could not be updated?
> >
>
Agreed. We do normally say that, this must be a bug.

> Why is there "post-commit processing" ?  shouldn't all processing be part of the
> transaction such that if any parts fail, the whole thing gets rolled back?
>
Because after the commit has succeded in the repository, the working copy
must be updated to reflect the actual revisions stored there. That's not
part of the server transaction

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: failed commit not totaly rolled back

Posted by Carl Karsten <ca...@personnelware.com>.
Joseph Galbraith wrote:
> Philip Martin wrote:
> 
>> Carl Karsten <ca...@personnelware.com> writes:
>>
>>> Adding         doc
>>> Adding  (bin)  doc\bp.odg
>>> Transmitting file data ..svn: Commit failed (details follow):
>>> svn: Error processing command 'committed' in 'C:\vfe\dev\WinPars\DATA'
>>> svn: Error replacing text-base of 'ErrorLog.FPT'
>>> svn: Can't copy
>>> 'C:\vfe\dev\WinPars\DATA\.svn\tmp\text-base\ErrorLog.FPT.svn-base' to
>>> 'C:\vfe\dev\WinPars\DATA\.svn\tmp\ErrorLog.FPT.tmp.tmp': There is not
>>> enough space on the disk.
>>>
>>> So I dump the 130mb of /temp files and try again.
>>
>>
>>> Adding         doc
>>> Adding  (bin)  doc\bp.odg
>>> Transmitting file data ..svn: Commit failed (details follow):
>>> svn: Out of date: 'DATA/ErrorLog.FPT' in transaction '16-1'
>>>
>>> It seems when the first attemt failed it didn't completely roll back
>>> everything it had started, which I am guessing is a bug?
>>
>>
>> No.  The first commit failed during post-commit processing of the
>> working copy, that's after the commit completed in the repository.
>> The failure means the working copy is out-of-date compared to the
>> repository, so the second commit fails.
> 
> 
> Definitely an error message that is a little confusing though...
> maybe it could be tweaked a bit to say that the commit succeeded,
> but the working copy could not be updated?
> 

Why is there "post-commit processing" ?  shouldn't all processing be part of the 
transaction such that if any parts fail, the whole thing gets rolled back?

^Carl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: failed commit not totaly rolled back

Posted by Joseph Galbraith <ga...@vandyke.com>.
Philip Martin wrote:
> Carl Karsten <ca...@personnelware.com> writes:
> 
>> Adding         doc
>> Adding  (bin)  doc\bp.odg
>> Transmitting file data ..svn: Commit failed (details follow):
>> svn: Error processing command 'committed' in 'C:\vfe\dev\WinPars\DATA'
>> svn: Error replacing text-base of 'ErrorLog.FPT'
>> svn: Can't copy
>> 'C:\vfe\dev\WinPars\DATA\.svn\tmp\text-base\ErrorLog.FPT.svn-base' to
>> 'C:\vfe\dev\WinPars\DATA\.svn\tmp\ErrorLog.FPT.tmp.tmp': There is not
>> enough space on the disk.
>>
>> So I dump the 130mb of /temp files and try again.
> 
>> Adding         doc
>> Adding  (bin)  doc\bp.odg
>> Transmitting file data ..svn: Commit failed (details follow):
>> svn: Out of date: 'DATA/ErrorLog.FPT' in transaction '16-1'
>>
>> It seems when the first attemt failed it didn't completely roll back
>> everything it had started, which I am guessing is a bug?
> 
> No.  The first commit failed during post-commit processing of the
> working copy, that's after the commit completed in the repository.
> The failure means the working copy is out-of-date compared to the
> repository, so the second commit fails.

Definitely an error message that is a little confusing though...
maybe it could be tweaked a bit to say that the commit succeeded,
but the working copy could not be updated?

Thanks,

Joseph

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: failed commit not totaly rolled back

Posted by Philip Martin <ph...@codematters.co.uk>.
Carl Karsten <ca...@personnelware.com> writes:

> Adding         doc
> Adding  (bin)  doc\bp.odg
> Transmitting file data ..svn: Commit failed (details follow):
> svn: Error processing command 'committed' in 'C:\vfe\dev\WinPars\DATA'
> svn: Error replacing text-base of 'ErrorLog.FPT'
> svn: Can't copy
> 'C:\vfe\dev\WinPars\DATA\.svn\tmp\text-base\ErrorLog.FPT.svn-base' to
> 'C:\vfe\dev\WinPars\DATA\.svn\tmp\ErrorLog.FPT.tmp.tmp': There is not
> enough space on the disk.
>
> So I dump the 130mb of /temp files and try again.

> Adding         doc
> Adding  (bin)  doc\bp.odg
> Transmitting file data ..svn: Commit failed (details follow):
> svn: Out of date: 'DATA/ErrorLog.FPT' in transaction '16-1'
>
> It seems when the first attemt failed it didn't completely roll back
> everything it had started, which I am guessing is a bug?

No.  The first commit failed during post-commit processing of the
working copy, that's after the commit completed in the repository.
The failure means the working copy is out-of-date compared to the
repository, so the second commit fails.

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org