[GitHub] [parquet-mr] yabola commented on a diff in pull request #1041: Uniformizing booleans naming in ParquetWriter

["yabola (via GitHub)" <gi...@apache.org>]

yabola commented on code in PR #1041:
URL: https://github.com/apache/parquet-mr/pull/1041#discussion_r1158495442


##########
parquet-column/src/main/java/org/apache/parquet/column/ParquetProperties.java:
##########
@@ -130,7 +130,7 @@ private ParquetProperties(Builder builder) {
     this.maxBloomFilterBytes = builder.maxBloomFilterBytes;
     this.pageRowCountLimit = builder.pageRowCountLimit;
     this.pageWriteChecksumEnabled = builder.pageWriteChecksumEnabled;
-    this.enableByteStreamSplit = builder.enableByteStreamSplit;
+    this.byteStreamSplitEnabled = builder.enableByteStreamSplit;

Review Comment:
   `builder.enableByteStreamSplit` should also rename as `byteStreamSplitEnabled`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org