You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2016/09/01 19:44:51 UTC
[Impala-CR] IMPALA-1112: Remove some unncessary code from cross-compilation
Hello Michael Ho, Internal Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4217
to review the following change.
Change subject: IMPALA-1112: Remove some unncessary code from cross-compilation
......................................................................
IMPALA-1112: Remove some unncessary code from cross-compilation
This change stops including some boost library header files
which pulls in other unnecessary boost library header files.
This reduces the amount of cross-compiled code which needs
to be materialized during codegen.
This change also removes some UDF's Prepare() and Close()
functions and UDF functions fromUtc(), toUtc() and uuid()
from cross-compilation as they won't benefit from it.
With this change, the bitcode module reduces from 2.12 MB to 1.86MB.
Change-Id: I543809c69da0b4085a0e299b91cd550b274c46af
Reviewed-on: http://gerrit.cloudera.org:8080/3793
Reviewed-by: Michael Ho <kw...@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit 27b3b4d470c6309729faba0b3872abf85f716f78)
---
M be/src/benchmarks/parse-timestamp-benchmark.cc
M be/src/common/init.cc
M be/src/exprs/CMakeLists.txt
M be/src/exprs/expr.cc
M be/src/exprs/timestamp-functions-ir.cc
A be/src/exprs/timestamp-functions.cc
M be/src/exprs/timestamp-functions.h
M be/src/exprs/timezone_db.cc
A be/src/exprs/timezone_db.h
M be/src/exprs/utility-functions-ir.cc
A be/src/exprs/utility-functions.cc
M be/src/exprs/utility-functions.h
M be/src/runtime/mem-tracker.cc
M be/src/runtime/timestamp-value.cc
M be/src/runtime/timestamp-value.h
M be/src/service/impala-http-handler.cc
M be/src/statestore/statestore.cc
M be/src/util/debug-util.cc
18 files changed, 331 insertions(+), 212 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/17/4217/1
--
To view, visit http://gerrit.cloudera.org:8080/4217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I543809c69da0b4085a0e299b91cd550b274c46af
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-CR] IMPALA-1112: Remove some unncessary code from cross-compilation
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has abandoned this change.
Change subject: IMPALA-1112: Remove some unncessary code from cross-compilation
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/4217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I543809c69da0b4085a0e299b91cd550b274c46af
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>