You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/07/26 15:56:00 UTC
[jira] [Work logged] (BEAM-7830) SparkPipelineResult
waitUntilFinish duration not consistent with PipelineResult
[ https://issues.apache.org/jira/browse/BEAM-7830?focusedWorklogId=283435&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-283435 ]
ASF GitHub Bot logged work on BEAM-7830:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jul/19 15:55
Start Date: 26/Jul/19 15:55
Worklog Time Spent: 10m
Work Description: regadas commented on pull request #9170: [BEAM-7830]: make spark default duration consistent with PipelineResult
URL: https://github.com/apache/beam/pull/9170
`DataflowPipelineJob` default duration on `waitUntilFinish` is `Duration.millis(-1)` which is inline with `PipelineResult#waitUntilFinish` doc <= 1ms results in infinite wait.
However, `SparkPipelineResult#waitUntilFinish` uses `Duration.millis(Long.MAX_VALUE)` hence not being consistent with `PipelineResult#waitUntilFinish`
R: @jbonofre
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 283435)
Time Spent: 10m
Remaining Estimate: 0h
> SparkPipelineResult waitUntilFinish duration not consistent with PipelineResult
> -------------------------------------------------------------------------------
>
> Key: BEAM-7830
> URL: https://issues.apache.org/jira/browse/BEAM-7830
> Project: Beam
> Issue Type: Bug
> Components: runner-spark
> Affects Versions: 2.13.0
> Reporter: Filipe Regadas
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> `DataflowPipelineJob` default duration on `waitUntilFinish` is `Duration.millis(-1)` which is inline with `PipelineResult#waitUntilFinish` doc <= 1ms results in infinite wait.
> However, `SparkPipelineResult#waitUntilFinish` uses `Duration.millis(Long.MAX_VALUE)` hence not being consistent with `PipelineResult#waitUntilFinish`
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)