You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/11/28 18:46:21 UTC
Re: Review Request 53962: CMake: Remove test-specific variables from
ProcessTestsConfigure.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53962/#review157089
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake
<https://reviews.apache.org/r/53962/#comment227508>
Just so I'm clear: this comment is being removed because we're moving away from the model where we `include(ProcessTestsConfigure)` and instead `include(StoutTestsConfigure)`? That's fine, I just want to be clear about it.
- Alex Clemmer
On Nov. 21, 2016, 10:08 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53962/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2016, 10:08 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
>
>
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The removed definitions are now defined in:
> `3rdparty/stout/cmake/StoutTestsConfigure.cmake`
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake c73c7a4960243917ad21f2d8a529575157eefa32
>
> Diff: https://reviews.apache.org/r/53962/diff/
>
>
> Testing
> -------
>
> See next review.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 53962: CMake: Remove test-specific variables from
ProcessTestsConfigure.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Nov. 28, 2016, 10:46 a.m., Alex Clemmer wrote:
> > 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake, line 18
> > <https://reviews.apache.org/r/53962/diff/1/?file=1568204#file1568204line18>
> >
> > Just so I'm clear: this comment is being removed because we're moving away from the model where we `include(ProcessTestsConfigure)` and instead `include(StoutTestsConfigure)`? That's fine, I just want to be clear about it.
Exactly. The comment is moved as well.
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53962/#review157089
-----------------------------------------------------------
On Nov. 21, 2016, 2:08 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53962/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2016, 2:08 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
>
>
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The removed definitions are now defined in:
> `3rdparty/stout/cmake/StoutTestsConfigure.cmake`
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake c73c7a4960243917ad21f2d8a529575157eefa32
>
> Diff: https://reviews.apache.org/r/53962/diff/
>
>
> Testing
> -------
>
> See next review.
>
>
> Thanks,
>
> Joseph Wu
>
>