You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Don Bosco Durai <bo...@apache.org> on 2016/01/12 23:51:17 UTC
Review Request 42219: RANGER-813 Script to install Solr for Ranger
Audits doesn't work in Suse
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42219/
-----------------------------------------------------------
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-813
https://issues.apache.org/jira/browse/RANGER-813
Repository: ranger
Description
-------
Using low level useradd command instead of convienince script adduser.
Diffs
-----
security-admin/contrib/solr_for_audit_setup/setup.sh 2ca1e6d
Diff: https://reviews.apache.org/r/42219/diff/
Testing
-------
Manually tested installing Solr on Suse
Thanks,
Don Bosco Durai
Re: Review Request 42219: RANGER-813 Script to install Solr for Ranger
Audits doesn't work in Suse
Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42219/#review114124
-----------------------------------------------------------
security-admin/contrib/solr_for_audit_setup/setup.sh (line 127)
<https://reviews.apache.org/r/42219/#comment174934>
This was to make sure the solr process owner has permission to log folder if it is nested. I agreed, we shouldn't do this, because it is getting applied for data folder also. Let me change it.
Thanks
- Don Bosco Durai
On Jan. 12, 2016, 10:51 p.m., Don Bosco Durai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42219/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 10:51 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-813
> https://issues.apache.org/jira/browse/RANGER-813
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Using low level useradd command instead of convienince script adduser.
>
>
> Diffs
> -----
>
> security-admin/contrib/solr_for_audit_setup/setup.sh 2ca1e6d
>
> Diff: https://reviews.apache.org/r/42219/diff/
>
>
> Testing
> -------
>
> Manually tested installing Solr on Suse
>
>
> Thanks,
>
> Don Bosco Durai
>
>
Re: Review Request 42219: RANGER-813 Script to install Solr for Ranger
Audits doesn't work in Suse
Posted by Don Bosco Durai <bo...@apache.org>.
> On Jan. 13, 2016, 9:18 p.m., Madhan Neethiraj wrote:
> > Bosco - the review does not work. Can you please check and update the review?
Seems some bug on the RB side. Can you download the patch and check it? Thanks
- Don Bosco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42219/#review114283
-----------------------------------------------------------
On Jan. 13, 2016, 8:43 p.m., Don Bosco Durai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42219/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 8:43 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-813
> https://issues.apache.org/jira/browse/RANGER-813
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Using low level useradd command instead of convienince script adduser.
>
>
> Diffs
> -----
>
> security-admin/contrib/solr_for_audit_setup/setup.sh 2ca1e6d
>
> Diff: https://reviews.apache.org/r/42219/diff/
>
>
> Testing
> -------
>
> Manually tested installing Solr on Suse
>
>
> Thanks,
>
> Don Bosco Durai
>
>
Re: Review Request 42219: RANGER-813 Script to install Solr for Ranger
Audits doesn't work in Suse
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42219/#review114283
-----------------------------------------------------------
Bosco - the review does not work. Can you please check and update the review?
- Madhan Neethiraj
On Jan. 13, 2016, 8:43 p.m., Don Bosco Durai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42219/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 8:43 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-813
> https://issues.apache.org/jira/browse/RANGER-813
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Using low level useradd command instead of convienince script adduser.
>
>
> Diffs
> -----
>
> security-admin/contrib/solr_for_audit_setup/setup.sh 2ca1e6d
>
> Diff: https://reviews.apache.org/r/42219/diff/
>
>
> Testing
> -------
>
> Manually tested installing Solr on Suse
>
>
> Thanks,
>
> Don Bosco Durai
>
>
Re: Review Request 42219: RANGER-813 Script to install Solr for Ranger
Audits doesn't work in Suse
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42219/#review114362
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Jan. 13, 2016, 8:43 p.m., Don Bosco Durai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42219/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 8:43 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-813
> https://issues.apache.org/jira/browse/RANGER-813
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Using low level useradd command instead of convienince script adduser.
>
>
> Diffs
> -----
>
> security-admin/contrib/solr_for_audit_setup/setup.sh 2ca1e6d
>
> Diff: https://reviews.apache.org/r/42219/diff/
>
>
> Testing
> -------
>
> Manually tested installing Solr on Suse
>
>
> Thanks,
>
> Don Bosco Durai
>
>
Re: Review Request 42219: RANGER-813 Script to install Solr for Ranger
Audits doesn't work in Suse
Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42219/
-----------------------------------------------------------
(Updated Jan. 13, 2016, 8:43 p.m.)
Review request for ranger and Madhan Neethiraj.
Changes
-------
Incorporated Madhan's feedback
Bugs: RANGER-813
https://issues.apache.org/jira/browse/RANGER-813
Repository: ranger
Description
-------
Using low level useradd command instead of convienince script adduser.
Diffs (updated)
-----
security-admin/contrib/solr_for_audit_setup/setup.sh 2ca1e6d
Diff: https://reviews.apache.org/r/42219/diff/
Testing
-------
Manually tested installing Solr on Suse
Thanks,
Don Bosco Durai
Re: Review Request 42219: RANGER-813 Script to install Solr for Ranger
Audits doesn't work in Suse
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42219/#review114220
-----------------------------------------------------------
security-admin/contrib/solr_for_audit_setup/setup.sh (line 128)
<https://reviews.apache.org/r/42219/#comment175035>
Consider moving 'if' in line #128 to outside the 'while' in line #126. In case "is_root != 1", the 'while' loop does nothing but iterate up to root folder name/
security-admin/contrib/solr_for_audit_setup/setup.sh (line 132)
<https://reviews.apache.org/r/42219/#comment175037>
Many installation steps are already executed by this time. Should the installation abort due to permission issue - without any cleanup? Consider the following options:
- continue the installtion after giving warning about each incorrect permission folder found (so that the user can manually update the permission)
- prompt the user to accept the permission update and have the script update the permission
- Madhan Neethiraj
On Jan. 13, 2016, 3:33 a.m., Don Bosco Durai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42219/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 3:33 a.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-813
> https://issues.apache.org/jira/browse/RANGER-813
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Using low level useradd command instead of convienince script adduser.
>
>
> Diffs
> -----
>
> security-admin/contrib/solr_for_audit_setup/setup.sh 2ca1e6d
>
> Diff: https://reviews.apache.org/r/42219/diff/
>
>
> Testing
> -------
>
> Manually tested installing Solr on Suse
>
>
> Thanks,
>
> Don Bosco Durai
>
>
Re: Review Request 42219: RANGER-813 Script to install Solr for Ranger
Audits doesn't work in Suse
Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42219/
-----------------------------------------------------------
(Updated Jan. 13, 2016, 3:33 a.m.)
Review request for ranger and Madhan Neethiraj.
Changes
-------
Instead of giving read permisisons to everyone, now giving appropriate error message and exiting
Bugs: RANGER-813
https://issues.apache.org/jira/browse/RANGER-813
Repository: ranger
Description
-------
Using low level useradd command instead of convienince script adduser.
Diffs (updated)
-----
security-admin/contrib/solr_for_audit_setup/setup.sh 2ca1e6d
Diff: https://reviews.apache.org/r/42219/diff/
Testing
-------
Manually tested installing Solr on Suse
Thanks,
Don Bosco Durai
Re: Review Request 42219: RANGER-813 Script to install Solr for Ranger
Audits doesn't work in Suse
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42219/#review114123
-----------------------------------------------------------
security-admin/contrib/solr_for_audit_setup/setup.sh (line 127)
<https://reviews.apache.org/r/42219/#comment174928>
ACL of all parent/ancestor directories are made world readable+traversable ("a+rx"). Is this necessary?
- Madhan Neethiraj
On Jan. 12, 2016, 10:51 p.m., Don Bosco Durai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42219/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 10:51 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-813
> https://issues.apache.org/jira/browse/RANGER-813
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Using low level useradd command instead of convienince script adduser.
>
>
> Diffs
> -----
>
> security-admin/contrib/solr_for_audit_setup/setup.sh 2ca1e6d
>
> Diff: https://reviews.apache.org/r/42219/diff/
>
>
> Testing
> -------
>
> Manually tested installing Solr on Suse
>
>
> Thanks,
>
> Don Bosco Durai
>
>