You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2013/07/30 10:50:50 UTC
Review Request 13057: CLOUDSTACK-2909: patch to fix TAB in US keyboard.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13057/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh and Fang Wang.
Bugs: CLOUDSTACK-2909
Repository: cloudstack-git
Description
-------
CLOUDSTACK-2909: patch to fix TAB in US keyboard.
Diffs
-----
services/console-proxy/server/js/ajaxkeys.js 725c8c5
Diff: https://reviews.apache.org/r/13057/diff/
Testing
-------
Verified the fix locally on Windows 7 as guestOS and Xenserver 6.2 as hypervisor.
Thanks,
Sanjay Tripathi
Re: Review Request 13057: CLOUDSTACK-2909: patch to fix TAB in US keyboard.
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13057/#review24226
-----------------------------------------------------------
Ship it!
Ship It!
- Devdeep Singh
On July 30, 2013, 8:50 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13057/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 8:50 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Fang Wang.
>
>
> Bugs: CLOUDSTACK-2909
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2909: patch to fix TAB in US keyboard.
>
>
> Diffs
> -----
>
> services/console-proxy/server/js/ajaxkeys.js 725c8c5
>
> Diff: https://reviews.apache.org/r/13057/diff/
>
>
> Testing
> -------
>
> Verified the fix locally on Windows 7 as guestOS and Xenserver 6.2 as hypervisor.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request 13057: CLOUDSTACK-2909: patch to fix TAB in US keyboard.
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13057/#review24219
-----------------------------------------------------------
Review 13057 PASSED the build test
The url of build cloudstack-master-with-patch #80 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/80/
- Jenkins Cloudstack.org
On July 30, 2013, 8:50 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13057/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 8:50 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Fang Wang.
>
>
> Bugs: CLOUDSTACK-2909
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2909: patch to fix TAB in US keyboard.
>
>
> Diffs
> -----
>
> services/console-proxy/server/js/ajaxkeys.js 725c8c5
>
> Diff: https://reviews.apache.org/r/13057/diff/
>
>
> Testing
> -------
>
> Verified the fix locally on Windows 7 as guestOS and Xenserver 6.2 as hypervisor.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request 13057: CLOUDSTACK-2909: patch to fix TAB in US keyboard.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13057/#review24221
-----------------------------------------------------------
Commit 7cb1c6fa7ba229484ec3e87ad5f50b35eeacf953 in branch refs/heads/4.2 from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7cb1c6f ]
CLOUDSTACK-2909: patch to fix TAB in US keyboard.
- ASF Subversion and Git Services
On July 30, 2013, 8:50 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13057/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 8:50 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Fang Wang.
>
>
> Bugs: CLOUDSTACK-2909
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2909: patch to fix TAB in US keyboard.
>
>
> Diffs
> -----
>
> services/console-proxy/server/js/ajaxkeys.js 725c8c5
>
> Diff: https://reviews.apache.org/r/13057/diff/
>
>
> Testing
> -------
>
> Verified the fix locally on Windows 7 as guestOS and Xenserver 6.2 as hypervisor.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request 13057: CLOUDSTACK-2909: patch to fix TAB in US keyboard.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13057/#review24223
-----------------------------------------------------------
Commit 6ec2bb1518898c55739f74a11d881b1ba587d94a in branch refs/heads/master from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6ec2bb1 ]
CLOUDSTACK-2909: patch to fix TAB in US keyboard.
- ASF Subversion and Git Services
On July 30, 2013, 8:50 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13057/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 8:50 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Fang Wang.
>
>
> Bugs: CLOUDSTACK-2909
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2909: patch to fix TAB in US keyboard.
>
>
> Diffs
> -----
>
> services/console-proxy/server/js/ajaxkeys.js 725c8c5
>
> Diff: https://reviews.apache.org/r/13057/diff/
>
>
> Testing
> -------
>
> Verified the fix locally on Windows 7 as guestOS and Xenserver 6.2 as hypervisor.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>