You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/04/22 08:03:04 UTC

[GitHub] [skywalking] dmsolr commented on a change in pull request #4690: Fix profile recheck error

dmsolr commented on a change in pull request #4690:
URL: https://github.com/apache/skywalking/pull/4690#discussion_r412761848



##########
File path: apm-checkstyle/checkStyle.xml
##########
@@ -96,7 +96,7 @@
             <property name="format" value="(^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$)"/>
         </module>
         <module name="PackageName">
-            <property name="format" value="^org\.apache\.skywalking(\.[a-zA-Z][a-zA-Z0-9]*)+$"/>
+            <property name="format" value="^(org|test)\.apache\.skywalking(\.[a-zA-Z][a-zA-Z0-9]*)+$"/>

Review comment:
       PluginTests don't enable checkstyle yet. ref #4377 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org