[jira] Commented: (TUSCANY-3023) Tuscany does not detect an error where a element defines its type with both @type and @element atributes

["Mike Edwards (JIRA)" <de...@tuscany.apache.org>]

    [ https://issues.apache.org/jira/browse/TUSCANY-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709430#action_12709430 ] 

Mike Edwards commented on TUSCANY-3023:
---------------------------------------

The bulk of the reading of the content of a <property/>  element is done in the org.apache.tuscany.sca.assembly.xml.BaseAssemblyProcessor class, in the readAbstractProperty() method.

Currently, the code simply reads in all the attributes of the <property/> element and makes no judgements on what it finds in those attributes.  This needs to change, since the presence of @type and @element together in a property is simply illegal.

I propose to add a check at the end of the readAbstractProperty() method which raises an error if both @type and @element are non-null.

> Tuscany does not detect an error where a <property/> element defines its type with both @type and @element atributes
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: TUSCANY-3023
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-3023
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA Assembly Model
>    Affects Versions: Java-SCA-2.0
>            Reporter: Mike Edwards
>            Assignee: Mike Edwards
>            Priority: Minor
>             Fix For: Java-SCA-2.0
>
>
> The OASIS SCA Assembly spec states that a <property/> element MUST NOT declare its type using both a @type and a @element attribute, such as:
> <property name="propertyName" element="sca:callback" type="sca:Callback"/>
> Currently, SCA fails even to notice that a property element is declared in this way.
> This is detected by the OASIS SCA Assembly testcase:
> ASM_4007_TestCase

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.