You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/08/30 19:20:00 UTC
[jira] [Commented] (HDFS-16753) WebHDFSHandler should reject non-compliant requests
[ https://issues.apache.org/jira/browse/HDFS-16753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598025#comment-17598025 ]
ASF GitHub Bot commented on HDFS-16753:
---------------------------------------
snmvaughan opened a new pull request, #4834:
URL: https://github.com/apache/hadoop/pull/4834
### Description of PR
When the nnId is not provided to the WebHDFSClient, the request uses null to generate a URI using a host name of "null" to construct a DFSClient instance. In environments where the host name "null" doesn't resolve, the test passes due to the unresolvable name. If the host name "null" does resolve, then this results in repeated attempts through the retry mechanism, eventually causing a timeout and a failed test result.
This change make the parameter a precondition for constructing the DFSClient, which throws an exception, rejecting the request, and return the expected 400 status code.
Make a non-null nnId a precondition for creating a DFSClient.
### How was this patch tested?
The patch was tested using both Maven Surefire and an IDE to demonstrate that the expected 400 status code was returned when the parameter was missing.
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
> WebHDFSHandler should reject non-compliant requests
> ---------------------------------------------------
>
> Key: HDFS-16753
> URL: https://issues.apache.org/jira/browse/HDFS-16753
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs
> Affects Versions: 3.4.0, 3.3.9
> Environment: Tested using both Maven Surefire and an IDE to demonstrate that the fix correctly rejects the invalid request with a 400 status code.
> Reporter: Steve Vaughan
> Assignee: Steve Vaughan
> Priority: Major
>
> When the nnId is not provided to the WebHDFSClient, the request uses null to generate a URI using a host name of "null" to construct a DFSClient instance. In environments where the host name "null" doesn't resolve, the test passes due to the unresolvable name. If the host name "null" does resolve, then this results in repeated attempts through the retry mechanism, eventually causing a timeout and a failed test result.
> This change make the parameter a precondition for constructing the DFSClient, which throws an exception, rejecting the request, and return the expected 400 status code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org