You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2024/01/18 07:23:24 UTC

[PR] [#1466] feat(server): introduce the JvmPauseMonitor to detect the gc pause [incubator-uniffle]

zuston opened a new pull request, #1470:
URL: https://github.com/apache/incubator-uniffle/pull/1470

   ### What changes were proposed in this pull request?
   
    introduce the JvmPauseMonitor to detect the gc pause
   
   ### Why are the changes needed?
   
   Fix: #1466 
   
   We have some loop check logic in shuffle-server, sometimes the GC pause will make some pre-allocated buffer  removed.
   If we have this monitor, we will find out this reason rather than guess. Although the JVM metrics are also valid.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Existing tests
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1466] feat(server): introduce the JvmPauseMonitor to detect the gc pause [incubator-uniffle]

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #1470:
URL: https://github.com/apache/incubator-uniffle/pull/1470


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1466] feat(server): introduce the JvmPauseMonitor to detect the gc pause [incubator-uniffle]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1470:
URL: https://github.com/apache/incubator-uniffle/pull/1470#issuecomment-1897946268

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1470?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: `81 lines` in your changes are missing coverage. Please review.
   > Comparison is base [(`25d0585`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/25d0585ddf6154e52ef01a7cbf9eb24809b7e585?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 54.12% compared to head [(`918c3cd`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1470?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 54.33%.
   
   | [Files](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1470?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/uniffle/common/util/JvmPauseMonitor.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1470?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi91dGlsL0p2bVBhdXNlTW9uaXRvci5qYXZh) | 0.00% | [80 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1470?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../java/org/apache/uniffle/server/ShuffleServer.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1470?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlU2VydmVyLmphdmE=) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1470?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1470      +/-   ##
   ============================================
   + Coverage     54.12%   54.33%   +0.21%     
   + Complexity     2773     2240     -533     
   ============================================
     Files           423      347      -76     
     Lines         24215    15702    -8513     
     Branches       2062     1441     -621     
   ============================================
   - Hits          13106     8532    -4574     
   + Misses        10296     6692    -3604     
   + Partials        813      478     -335     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1470?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1466] feat(server): introduce the JvmPauseMonitor to detect the gc pause [incubator-uniffle]

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1470:
URL: https://github.com/apache/incubator-uniffle/pull/1470#issuecomment-1898223858

   > Why do we need this after we already have JVM metrics?
   
   Sometimes the metric system is not enabled. BTW this class is referred from Hadoop https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1466] feat(server): introduce the JvmPauseMonitor to detect the gc pause [incubator-uniffle]

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1470:
URL: https://github.com/apache/incubator-uniffle/pull/1470#issuecomment-1898016981

   Why do we need this after we already have JVM metrics?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org