[GitHub] [samza] cameronlee314 opened a new pull request #1235: SAMZA-2418: Integration tests are failing and do not properly pass params to zopkio

[GitBox <gi...@apache.org>]

cameronlee314 opened a new pull request #1235: SAMZA-2418: Integration tests are failing and do not properly pass params to zopkio
URL: https://github.com/apache/samza/pull/1235
 
 
   **Symptom**: `./bin/integration-tests.sh /tmp/samza-tests yarn-integration-tests --nopassword` fails and does not respect the `--nopassword` parameter. Some of the documentation for testing does not have the correct commands for executing tests (i.e. missing `yarn-integration-tests` or `standalone-integration-tests` argument)
   **Cause**:
   1. The slf4j binding was removed by https://github.com/apache/samza/pull/985, but the integration test depends on some of those stdout logs.
   2. An additional `yarn-integration-tests` or `standalone-integration-tests` argument was added by https://github.com/apache/samza/pull/554, but it looks like the argument parsing was not correctly updated to find the zopkio parameters. Also, not all of the test documentation was updated in that change.
   **Fix**:
   1. Add log4j2 dependency and log4j2.xml back in to the samza-test module so the integration test package which pick it up and send logs to stdout.
   2. Fixed the argument parsing to use the correct argument slice. I also changed `"${*:3}"` to `"${@:3}"` since `@` seems to be the cleaner in general (https://unix.stackexchange.com/questions/41571/what-is-the-difference-between-and); although I think `*` still worked in this case.
   **Tests**:
   1. Verified that `./bin/integration-tests.sh /tmp/samza-tests yarn-integration-tests --nopassword` and `./bin/integration-tests.sh standalone-integration-tests --nopassword` both succeed and do not ask for a password.
   2. `./bin/integration-tests.sh /tmp/samza-tests yarn-integration-tests` got to the stage where zopkio asked for a password.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services