You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/09/20 21:20:00 UTC
[jira] [Commented] (IMPALA-3926) Reconsider use of LD_LIBRARY_PATH
for toolchain libraries
[ https://issues.apache.org/jira/browse/IMPALA-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934772#comment-16934772 ]
ASF subversion and git services commented on IMPALA-3926:
---------------------------------------------------------
Commit 9c367968d00be3e1880c07494dd82ecf077e7ec0 in impala's branch refs/heads/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=9c36796 ]
IMPALA-3926: part 1: bump toolchain for rpath fixes
This bumps the toolchain to a version that sets up relative
rpaths correctly, removing the need to set LD_LIBRARY_PATH
when calling binaries or using shared objects from the toolchain.
rpaths embedded in the binaries and shared objects take precedence
over LD_LIBRARY_PATH, so the new binaries will link against the
shared libraries from the toolchain, as expected.
This does not attempt to clean up LD_LIBRARY_PATH yet -
that would not work for developers who have older versions
of the binaries on their system. We will do that later,
but give devs a window to switch over to the new toolchain.
Change-Id: I2abe513ebf4f459aa3e0c65c77ce7be8b8ca1221
Reviewed-on: http://gerrit.cloudera.org:8080/14274
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
> Reconsider use of LD_LIBRARY_PATH for toolchain libraries
> ---------------------------------------------------------
>
> Key: IMPALA-3926
> URL: https://issues.apache.org/jira/browse/IMPALA-3926
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: Impala 2.6.0
> Reporter: Matthew Jacobs
> Assignee: Tim Armstrong
> Priority: Major
> Labels: build, toolchain
>
> Right now, impala-config.sh puts a lot of libraries in LD_LIBRARY_PATH, but this can be a problem for binaries that aren't from our builds or explicitly built against these specific libraries. One solution is to move any tools we need into the toolchain and build against these libraries. While this may be a reasonable thing to do (i.e. moving all tools we need into the toolchain), we should consider if setting LD_LIBRARY_PATH for the whole Impala environment is really necessary and the right thing to do (e.g. [some people say using LD_LIBRARY_PATH is bad|http://xahlee.info/UnixResource_dir/_/ldpath.html]).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org