[GitHub] [lucene] rmuir commented on pull request #12343: Omit copying for creation of `Terms` from `CharSequence`s

["rmuir (via GitHub)" <gi...@apache.org>]

rmuir commented on PR #12343:
URL: https://github.com/apache/lucene/pull/12343#issuecomment-1572183658

   I think look at how QueryBuilder does this:
   
   ```
   new Term(field, termAtt.getBytesRef())
   ```
   
   I don't see any benefit of adding yet another way to do it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org