You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2017/03/27 11:48:16 UTC
[GitHub] flink pull request #3619: [FLINK-6157] [core] Make TypeInformation fully ser...
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/3619
[FLINK-6157] [core] Make TypeInformation fully serializable
This PR ensures that all type information in flink-core, flink-java, flink-scala is serializable. It introduces a test base for type information.
@StephanEwen as you suggested, I added a test that scans the class path for type information and checks test coverage, however, I had to modify many Maven pom.xml to achieve this. I don't know if we want that. Type information in other modules such as Gelly or Table API is not checked yet.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-6157
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3619.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3619
----
commit d59900417e48e00d3f4e6a682231937cbd185418
Author: twalthr <tw...@apache.org>
Date: 2017-03-27T08:33:58Z
[FLINK-6157] [core] Make TypeInformation fully serializable
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3619: [FLINK-6157] [core] Make TypeInformation fully serializab...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3619
+1 LGTM.
My only thought is if a user passes test data with more than one implementation of `TypeInformation` (and passing the `canEquals` test) then the check for `hashCode` and `equals` would only run on the first instance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3619: [FLINK-6157] [core] Make TypeInformation fully serializab...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3619
Related test failure on travis:
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project flink-core: Compilation failure: Compilation failure:
[ERROR] /home/travis/build/apache/flink/flink-core/src/test/java/org/apache/flink/api/java/typeutils/EnumTypeInfoTest.java:[31,41] incompatible types: cannot infer type arguments for org.apache.flink.api.java.typeutils.EnumTypeInfo<>
[ERROR] reason: inference variable T has incompatible bounds
[ERROR] equality constraints: org.apache.flink.api.java.typeutils.EnumTypeInfoTest.TestEnum
[ERROR] upper bounds: java.lang.Enum<capture#1 of ?>,java.lang.Enum<T>
[ERROR] /home/travis/build/apache/flink/flink-core/src/test/java/org/apache/flink/api/java/typeutils/EnumTypeInfoTest.java:[32,41] incompatible types: cannot infer type arguments for org.apache.flink.api.java.typeutils.EnumTypeInfo<>
[ERROR] reason: inference variable T has incompatible bounds
[ERROR] equality constraints: org.apache.flink.api.java.typeutils.EnumTypeInfoTest.AlternativeEnum
[ERROR] upper bounds: java.lang.Enum<capture#1 of ?>,java.lang.Enum<T>
[ERROR] -> [Help 1]
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3619: [FLINK-6157] [core] Make TypeInformation fully ser...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3619
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3619: [FLINK-6157] [core] Make TypeInformation fully serializab...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3619
@greghogan thanks for reviewing. I will add a loop around the test you mentioned such that every test datum is compared with every other test datum.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---