You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/10/21 06:33:43 UTC
[GitHub] [hbase] virajjasani commented on a change in pull request #735:
HBASE-22679 : Revamping CellUtil
virajjasani commented on a change in pull request #735: HBASE-22679 : Revamping CellUtil
URL: https://github.com/apache/hbase/pull/735#discussion_r336854370
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
##########
@@ -714,39 +418,13 @@ public boolean advance() {
};
}
- /**
- * @param left
- * @param right
- * @return True if the rows in <code>left</code> and <code>right</code> Cells match
- * @deprecated As of release 2.0.0, this will be removed in HBase 3.0.0.
- * Instead use {@link #matchingRows(Cell, Cell)}
- */
- @Deprecated
- public static boolean matchingRow(final Cell left, final Cell right) {
- return matchingRows(left, right);
- }
-
- /**
- * @deprecated As of release 2.0.0, this will be removed in HBase 3.0.0.
- * Instead use {@link #matchingRows(Cell, byte[])}
- */
- @Deprecated
- public static boolean matchingRow(final Cell left, final byte[] buf) {
- return matchingRows(left, buf);
- }
-
public static boolean matchingRows(final Cell left, final byte[] buf) {
if (buf == null) {
return left.getRowLength() == 0;
}
return PrivateCellUtil.matchingRows(left, buf, 0, buf.length);
}
- public static boolean matchingRow(final Cell left, final byte[] buf, final int offset,
Review comment:
It is fine to remove this, not being used anywhere
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services