You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "gerbermichi (via GitHub)" <gi...@apache.org> on 2024/12/16 14:40:30 UTC
[PR] feat(sunburst): Add node click functionality to sunburst chart [superset]
gerbermichi opened a new pull request, #31478:
URL: https://github.com/apache/superset/pull/31478
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
This feature introduces node click functionality to the sunburst chart. Users can now click on nodes to focus on one node, enhancing the interactivity and usability of the chart.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="1438" alt="image" src="https://github.com/user-attachments/assets/1d3749db-b382-4bb1-b182-996f3a96facc" />
<img width="1013" alt="image" src="https://github.com/user-attachments/assets/092f5f52-e0ef-4857-827b-4e5436daf76c" />
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
Create a sunburst chart with multiple hierarchies.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(sunburst): Add node click functionality to sunburst chart [superset]
Posted by "gerbermichi (via GitHub)" <gi...@apache.org>.
gerbermichi closed pull request #31478: feat(sunburst): Add node click functionality to sunburst chart
URL: https://github.com/apache/superset/pull/31478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(sunburst): Add node click functionality to sunburst chart [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on code in PR #31478:
URL: https://github.com/apache/superset/pull/31478#discussion_r1887249879
##########
superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/controlPanel.tsx:
##########
@@ -91,6 +91,18 @@ const config: ControlPanelConfig = {
},
},
],
+ [
+ {
+ name: 'node_click',
+ config: {
+ type: 'CheckboxControl',
+ label: t('Node Click'),
Review Comment:
Can we use a label that describes the feature it enables rather than action? Like `label: t('Enable drill down'),`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(sunburst): Add node click functionality to sunburst chart [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #31478:
URL: https://github.com/apache/superset/pull/31478#discussion_r1887574455
##########
superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/controlPanel.tsx:
##########
@@ -91,6 +91,18 @@ const config: ControlPanelConfig = {
},
},
],
+ [
+ {
+ name: 'node_click',
+ config: {
+ type: 'CheckboxControl',
+ label: t('Node Click'),
Review Comment:
Why not implement drill down using drill by as we do for all chart types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(sunburst): Add node click functionality to sunburst chart [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #31478:
URL: https://github.com/apache/superset/pull/31478#issuecomment-2546254381
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(sunburst): Add node click functionality to sunburst chart [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on code in PR #31478:
URL: https://github.com/apache/superset/pull/31478#discussion_r1887448114
##########
superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/controlPanel.tsx:
##########
@@ -91,6 +91,18 @@ const config: ControlPanelConfig = {
},
},
],
+ [
+ {
+ name: 'node_click',
+ config: {
+ type: 'CheckboxControl',
+ label: t('Node Click'),
Review Comment:
Oh you're right, this feature would be in conflict with cross filtering. I wonder if it would make sense to trigger drill down with some combination like ctrl + left click. Of course then we'd need some tooltip in chart itself for discoverability
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(sunburst): Add node click functionality to sunburst chart [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #31478:
URL: https://github.com/apache/superset/pull/31478#discussion_r1887308913
##########
superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/controlPanel.tsx:
##########
@@ -91,6 +91,18 @@ const config: ControlPanelConfig = {
},
},
],
+ [
+ {
+ name: 'node_click',
+ config: {
+ type: 'CheckboxControl',
+ label: t('Node Click'),
Review Comment:
@kgabryje I'm wondering what's the relationship of this feature with cross-filtering and drill by? By default, charts offer the left click for cross-filtering and the right-click for the menu options. They don't offer controls to enable/disable this behavior if I'm not mistaken. I wonder if we should just add support for left/right clicks as the other chart types do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org