You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "jhl221123 (via GitHub)" <gi...@apache.org> on 2025/07/16 12:33:00 UTC

[PR] Correct log message format in `AbstractDriverManagerConnectionSource` [logging-log4j2]

jhl221123 opened a new pull request, #3831:
URL: https://github.com/apache/logging-log4j2/pull/3831

   The debug log message in `AbstractDriverManagerConnectionSource` had 4 placeholders but was supplied with 5 arguments. This corrects the format string to match the argument count, resolving the warning.
   
   Fixes #3828
   
   ## Checklist
   
   Before we can review and merge your changes, please go through the checklist below. If you're still working on some items, feel free to submit your pull request as a draft—our CI will help guide you through the remaining steps.
   
   ### ✅ Required checks
   
   - [X] **License**: I confirm that my changes are submitted under the [Apache License, Version 2.0](https://apache.org/licenses/LICENSE-2.0).
   - [X] **Commit signatures**: All commits are signed and verifiable. (See [GitHub Docs on Commit Signature Verification](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)).
   - [X] **Code formatting**: The code is formatted according to the project’s style guide.
     <details>
       <summary>How to check and fix formatting</summary>
   
       - To **check** formatting: `./mvnw spotless:check`
       - To **fix** formatting: `./mvnw spotless:apply`
   
       See [the build instructions](https://logging.apache.org/log4j/2.x/development.html#building) for details.
     </details>
   - [X] **Build & Test**: I verified that the project builds and all unit tests pass.
     <details>
       <summary>How to build the project</summary>
   
       Run: `./mvnw verify`
   
       See [the build instructions](https://logging.apache.org/log4j/2.x/development.html#building) for details.
     </details>
   
   ### 🧪 Tests (select one)
   
   - [ ] I have added or updated tests to cover my changes.
   - [X] No additional tests are needed for this change.
   
   ### 📝 Changelog (select one)
   
   - [ ] I added a changelog entry in `src/changelog/.2.x.x`. (See [Changelog Entry File Guide](https://logging.apache.org/log4j/tools/log4j-changelog.html#changelog-entry-file)).
   - [X] This is a trivial change and does not require a changelog entry.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Correct log message format in `AbstractDriverManagerConnectionSource` [logging-log4j2]

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #3831:
URL: https://github.com/apache/logging-log4j2/pull/3831#issuecomment-3084175593

   Hi @jhl221123,
   
   Could you please add a changelog entry to this PR? While it's just a one-liner, it addresses a concrete issue reported by a user and deserves to be documented.
   
   **Also**, we've noticed you've been actively contributing to Log4j since May—thank you for your continued efforts! We'd love to get to know you better and chat about ways you could get more involved with the project. If you're interested, feel free to send me a quick email or book a call via my Zeeg link—both are available on my profile.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Correct log message format in `AbstractDriverManagerConnectionSource` [logging-log4j2]

Posted by "jhl221123 (via GitHub)" <gi...@apache.org>.
jhl221123 commented on PR #3831:
URL: https://github.com/apache/logging-log4j2/pull/3831#issuecomment-3089782222

   Hi @ppkarwasz,
   
   Thank you for the feedback and the very kind words! I've added the changelog entry as requested.
   
   I'm honored by the offer to connect and discuss getting more involved. I will definitely reach out via email shortly.
   Thanks again for your guidance!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Correct log message format in `AbstractDriverManagerConnectionSource` [logging-log4j2]

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz merged PR #3831:
URL: https://github.com/apache/logging-log4j2/pull/3831


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Correct log message format in `AbstractDriverManagerConnectionSource` [logging-log4j2]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3831:
URL: https://github.com/apache/logging-log4j2/pull/3831#issuecomment-3080201580

   
   
   <table>
       <tr>
           <th>Job</th>
           <th>Requested goals</th>
           <th>Build Tool Version</th>
           <th>Build Outcome</th>
           <th>Build Scan®</th>
       </tr>
       <tr>
           <td>build-macos-latest</td>
           <td>clean install</td>
           <td align='center'>3.9.8</td>
           <td align='center'>:white_check_mark:</td>
           <td><a href="https://develocity.apache.org/s/5ezlecvxnua44" rel="nofollow"><img src="https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle" alt="Build Scan PUBLISHED" /></a></td>
       </tr>
       <tr>
           <td>build-ubuntu-latest</td>
           <td>clean install</td>
           <td align='center'>3.9.8</td>
           <td align='center'>:white_check_mark:</td>
           <td><a href="https://develocity.apache.org/s/rxlllfturean6" rel="nofollow"><img src="https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle" alt="Build Scan PUBLISHED" /></a></td>
       </tr>
       <tr>
           <td>build-windows-latest</td>
           <td>clean install</td>
           <td align='center'>3.9.8</td>
           <td align='center'>:white_check_mark:</td>
           <td><a href="https://develocity.apache.org/s/jsxgspawoicd4" rel="nofollow"><img src="https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle" alt="Build Scan PUBLISHED" /></a></td>
       </tr>
   </table>
       
   
   ###### Generated by gradle/develocity-actions
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org