[GitHub] [solr] epugh commented on a diff in pull request #930: SOLR-16281: review boxing unboxing

[GitBox <gi...@apache.org>]

epugh commented on code in PR #930:
URL: https://github.com/apache/solr/pull/930#discussion_r913180601


##########
solr/core/src/test/org/apache/solr/handler/component/TestPivotHelperCode.java:
##########
@@ -89,8 +89,7 @@ public void testCompareWithNullLast() {
     assertEquals(a.compareTo(b), PivotFacetFieldValueCollection.compareWithNullLast(a, b));
     assertEquals(b.compareTo(a), PivotFacetFieldValueCollection.compareWithNullLast(b, a));
 
-    Long bb = new Long(b.longValue());
-    assertEquals(0, PivotFacetFieldValueCollection.compareWithNullLast(b, bb));
+    assertEquals(0, PivotFacetFieldValueCollection.compareWithNullLast(b, b));

Review Comment:
   As I edited it, I wondered if you were going to call this one out!  Eagle Eyes!    I could totally be swayed to undo it.     The line `Long bb = new Long(b.longValue()); ` means we are basically testing Java functionality???    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org