You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Percy Camilo Triveño Aucahuasi (Jira)" <ji...@apache.org> on 2022/09/15 03:13:00 UTC
[jira] [Comment Edited] (ARROW-17686) [C++] AsofJoinBasicParams has no gtest printer defined, leading to valgrind errors
[ https://issues.apache.org/jira/browse/ARROW-17686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605075#comment-17605075 ]
Percy Camilo Triveño Aucahuasi edited comment on ARROW-17686 at 9/15/22 3:12 AM:
---------------------------------------------------------------------------------
Still getting this report:
{code:java}
==14627== LEAK SUMMARY:
==14627== definitely lost: 0 bytes in 0 blocks
==14627== indirectly lost: 0 bytes in 0 blocks
==14627== possibly lost: 0 bytes in 0 blocks
==14627== still reachable: 12,063 bytes in 194 blocks
==14627== suppressed: 672 bytes in 2 blocks
==14627==
==14627== For lists of detected and suppressed errors, rerun with: -s
==14627== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 2 from 2){code}
and bunch of warnings from google8protobuf25EncodedDescriptorDatabase3AddEPKvi. I ran:
{code:java}
valgrind --suppressions=/somedir/arrow/cpp/valgrind.supp --tool=memcheck --gen-suppressions=all --num-callers=500 --leak-check=full --leak-check-heuristics=stdstring --error-exitcode=1 --show-leak-kinds=all debug/arrow-compute-asof-join-node-test{code}
What is the output you are getting? (I'm using dockerized linux container arm64v8 ubuntu 22.04 with gcc toolchain), this was the set of the cmake args:
-DCMAKE_INSTALL_LIBDIR=lib
-DARROW_BUILD_EXAMPLES=ON
-DARROW_BUILD_TESTS=ON
-DARROW_ENABLE_TIMING_TESTS=ON
-DARROW_BUILD_INTEGRATION=ON
-DARROW_BUILD_BENCHMARKS=OFF
-DARROW_BUILD_BENCHMARKS_REFERENCE=OFF
-DARROW_BUILD_OPENMP_BENCHMARKS=OFF
-DARROW_BUILD_DETAILED_BENCHMARKS=OFF
-DARROW_TEST_LINKAGE=shared
-DARROW_FUZZING=OFF
-DARROW_LARGE_MEMORY_TESTS=OFF
-DARROW_WITH_OPENTELEMETRY=ON
-DARROW_WITH_BZ2=ON
-DARROW_WITH_ZLIB=ON
-DARROW_WITH_ZSTD=ON
-DARROW_WITH_LZ4=ON
-DARROW_WITH_THRIFT=ON
-DARROW_WITH_SNAPPY=ON
-DARROW_WITH_BROTLI=ON
-DARROW_WITH_ZLIB=ON
-DARROW_PARQUET=ON
-DARROW_ORC=ON
-DARROW_PYTHON=ON
-DARROW_COMPUTE=ON
-DARROW_CSV=ON
-DARROW_DATASET=ON
-DARROW_EXTRA_ERROR_CONTEXT=ON
-DARROW_FILESYSTEM=ON
-DARROW_INSTALL_NAME_RPATH=OFF
-DARROW_JEMALLOC=ON
-DARROW_JSON=ON
-DARROW_CUDA=OFF
-DARROW_BUILD_STATIC=OFF
-DARROW_S3=OFF
-DARROW_HDFS=OFF
-DARROW_GCS=OFF
-DARROW_FLIGHT=ON
-DARROW_BUILD_UTILITIES=ON
-DARROW_EXTRA_ERROR_CONTEXT=ON
-DARROW_USE_CCACHE=ON
-DCMAKE_UNITY_BUILD=OFF
-DARROW_USE_PRECOMPILED_HEADERS=OFF
-DBUILD_WARNING_LEVEL=CHECKIN
-DCMAKE_BUILD_TYPE=Debug
was (Author: aucahuasi):
Still getting this report:
{code:java}
==14627== LEAK SUMMARY:
==14627== definitely lost: 0 bytes in 0 blocks
==14627== indirectly lost: 0 bytes in 0 blocks
==14627== possibly lost: 0 bytes in 0 blocks
==14627== still reachable: 12,063 bytes in 194 blocks
==14627== suppressed: 672 bytes in 2 blocks
==14627==
==14627== For lists of detected and suppressed errors, rerun with: -s
==14627== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 2 from 2){code}
and bunch of warnings from google8protobuf25EncodedDescriptorDatabase3AddEPKvi. I ran:
{code:java}
valgrind --suppressions=/somedir/arrow/cpp/valgrind.supp --tool=memcheck --gen-suppressions=all --num-callers=500 --leak-check=full --leak-check-heuristics=stdstring --error-exitcode=1 --show-leak-kinds=all debug/arrow-compute-asof-join-node-test{code}
What is the output you are getting? (I'm using linux arm64v8 ubuntu 22.04 with gcc toolchain), this was the set of the cmake args:
-DCMAKE_INSTALL_LIBDIR=lib
-DARROW_BUILD_EXAMPLES=ON
-DARROW_BUILD_TESTS=ON
-DARROW_ENABLE_TIMING_TESTS=ON
-DARROW_BUILD_INTEGRATION=ON
-DARROW_BUILD_BENCHMARKS=OFF
-DARROW_BUILD_BENCHMARKS_REFERENCE=OFF
-DARROW_BUILD_OPENMP_BENCHMARKS=OFF
-DARROW_BUILD_DETAILED_BENCHMARKS=OFF
-DARROW_TEST_LINKAGE=shared
-DARROW_FUZZING=OFF
-DARROW_LARGE_MEMORY_TESTS=OFF
-DARROW_WITH_OPENTELEMETRY=ON
-DARROW_WITH_BZ2=ON
-DARROW_WITH_ZLIB=ON
-DARROW_WITH_ZSTD=ON
-DARROW_WITH_LZ4=ON
-DARROW_WITH_THRIFT=ON
-DARROW_WITH_SNAPPY=ON
-DARROW_WITH_BROTLI=ON
-DARROW_WITH_ZLIB=ON
-DARROW_PARQUET=ON
-DARROW_ORC=ON
-DARROW_PYTHON=ON
-DARROW_COMPUTE=ON
-DARROW_CSV=ON
-DARROW_DATASET=ON
-DARROW_EXTRA_ERROR_CONTEXT=ON
-DARROW_FILESYSTEM=ON
-DARROW_INSTALL_NAME_RPATH=OFF
-DARROW_JEMALLOC=ON
-DARROW_JSON=ON
-DARROW_CUDA=OFF
-DARROW_BUILD_STATIC=OFF
-DARROW_S3=OFF
-DARROW_HDFS=OFF
-DARROW_GCS=OFF
-DARROW_FLIGHT=ON
-DARROW_BUILD_UTILITIES=ON
-DARROW_EXTRA_ERROR_CONTEXT=ON
-DARROW_USE_CCACHE=ON
-DCMAKE_UNITY_BUILD=OFF
-DARROW_USE_PRECOMPILED_HEADERS=OFF
-DBUILD_WARNING_LEVEL=CHECKIN
-DCMAKE_BUILD_TYPE=Debug
> [C++] AsofJoinBasicParams has no gtest printer defined, leading to valgrind errors
> ----------------------------------------------------------------------------------
>
> Key: ARROW-17686
> URL: https://issues.apache.org/jira/browse/ARROW-17686
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Weston Pace
> Assignee: Percy Camilo Triveño Aucahuasi
> Priority: Major
>
> Valgrind is currently failing on arrow-compute-asof-join-node-test: https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=34147&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=d9b15392-e4ce-5e4c-0c8c-b69645229181&l=4118
> The issue appears to be that AsofJoinBasicParams has no gtest printer and so gtest is using the default universal-printer which doesn't really play well with valgrind. We should add a custom PrintTo method for AsofJoinBasicParams per: https://github.com/google/googletest/blob/main/googletest/include/gtest/gtest-printers.h
--
This message was sent by Atlassian Jira
(v8.20.10#820010)