You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@opennlp.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/02/15 20:16:41 UTC

[jira] [Commented] (OPENNLP-229) Write a test case for the NameFinderSequenceValidator class

    [ https://issues.apache.org/jira/browse/OPENNLP-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868499#comment-15868499 ] 

ASF GitHub Bot commented on OPENNLP-229:
----------------------------------------

GitHub user thygesen opened a pull request:

    https://github.com/apache/opennlp/pull/125

    OPENNLP-229: Write a test case for the NameFinderSequenceValidator class

    I have written the missing test for NameFinderSequenceValidator. Please note that the test:testContinueAfterStartAndNotSameType has temporary been disabled because it will fail due to a minor "bug" in the NameFinderSequenceValidator. At the moment the validator accepts Continue after Start even though they are different name types. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thygesen/opennlp opennlp-229

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/opennlp/pull/125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #125
    
----
commit 5c29df047778fb1ac3d9773c27c001291a52112c
Author: Peter Thygesen <pe...@gmail.com>
Date:   2017-02-15T20:12:48Z

    Added test for NameFinderSequenceValidator

----


> Write a test case for the NameFinderSequenceValidator class
> -----------------------------------------------------------
>
>                 Key: OPENNLP-229
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-229
>             Project: OpenNLP
>          Issue Type: Task
>          Components: Name Finder
>            Reporter: Joern Kottmann
>            Assignee: Peter Thygesen
>            Priority: Minor
>             Fix For: 1.8.0
>
>         Attachments: OPENNLP-229.patch, OPENNLP-229.patch, patch_OPENNLP-229_added.patch, patch_OPENNLP-229.java
>
>
> The NameFinderSequenceValidator is public now, and that makes it possible to write a test for it. The test should check that the sequence validation works as expected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)