You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2016/01/19 23:02:39 UTC
[jira] [Commented] (MNG-5934) String handling issues identified by
PMD
[ https://issues.apache.org/jira/browse/MNG-5934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107544#comment-15107544 ]
Hudson commented on MNG-5934:
-----------------------------
SUCCESS: Integrated in maven-3.x #1195 (See [https://builds.apache.org/job/maven-3.x/1195/])
[MNG-5934] String handling issues identified by PMD Submitted by: Alex (schulte: rev 2d3b5811566190b52840e27cd04eb26bd02bb1b4)
* maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
* maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraphVertex.java
* maven-core/src/main/java/org/apache/maven/project/MavenProject.java
* maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraph.java
* maven-artifact/src/main/java/org/apache/maven/artifact/repository/ArtifactRepositoryPolicy.java
* maven-compat/src/test/java/org/apache/maven/project/LegacyLocalRepositoryManager.java
* maven-compat/src/main/java/org/apache/maven/artifact/versioning/ManagedVersionMap.java
* maven-builder-support/src/main/java/org/apache/maven/building/DefaultProblem.java
* maven-artifact/src/main/java/org/apache/maven/artifact/versioning/Restriction.java
* maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
* maven-core/src/main/java/org/apache/maven/lifecycle/LifecycleExecutionException.java
* maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java
* maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/AbstractRepositoryMetadata.java
* maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/UnsupportedSlf4jBindingConfiguration.java
* maven-core/src/main/java/org/apache/maven/repository/ArtifactTransferEvent.java
* maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
* maven-embedder/src/test/java/org/apache/maven/cli/CLIManagerDocumentationTest.java
* maven-plugin-api/src/main/java/org/apache/maven/plugin/MojoNotFoundException.java
* maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java
* maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProblemUtils.java
* maven-core/src/test/java/org/apache/maven/project/LegacyLocalRepositoryManager.java
* maven-compat/src/main/java/org/apache/maven/project/validation/ModelValidationResult.java
* maven-core/src/main/java/org/apache/maven/repository/legacy/metadata/AbstractArtifactMetadata.java
* maven-compat/src/main/java/org/apache/maven/artifact/repository/DefaultArtifactRepository.java
* maven-embedder/src/main/java/org/apache/maven/cli/CLIReportingUtils.java
* maven-artifact/src/main/java/org/apache/maven/artifact/resolver/AbstractArtifactResolutionException.java
* maven-core/src/main/java/org/apache/maven/artifact/resolver/ArtifactResolutionResult.java
* maven-compat/src/test/java/org/apache/maven/project/inheritance/AbstractProjectInheritanceTestCase.java
* maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java
* maven-settings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsProblem.java
* maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelProblem.java
* maven-core/src/main/java/org/apache/maven/plugin/MojoExecution.java
* maven-artifact/src/main/java/org/apache/maven/artifact/DefaultArtifact.java
* maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java
* maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionResult.java
* maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
* maven-core/src/main/java/org/apache/maven/lifecycle/mapping/LifecyclePhase.java
* maven-artifact/src/main/java/org/apache/maven/artifact/resolver/MultipleArtifactsNotFoundException.java
* maven-core/src/main/java/org/apache/maven/plugin/PluginParameterException.java
> String handling issues identified by PMD
> ----------------------------------------
>
> Key: MNG-5934
> URL: https://issues.apache.org/jira/browse/MNG-5934
> Project: Maven
> Issue Type: Improvement
> Affects Versions: 3.3.9
> Reporter: Alex Henrie
> Assignee: Christian Schulte
> Priority: Minor
> Labels: easyfix, newbie, patch, performance
> Fix For: 3.4.0
>
> Attachments: 0001-Prefer-StringBuilder.append-char-to-StringBuilder.ap.patch, 0002-Prefer-String.indexOf-char-to-String.indexOf-String.patch, 0003-Combine-string-literals-instead-of-calling-String.ap.patch, 0004-Construct-StringBuffers-with-enough-space-to-begin-w.patch
>
>
> The code linting tool [PMD|http://pmd.sourceforge.net/pmd-5.2.0/] identified numerous places where Maven's string handling is inefficient. I've prepared a set of patches that should help speed things up.
> The command I used was `pmd -d . -R java-strings`
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)