[GitHub] [ozone] sky76093016 commented on a change in pull request #2917: HDDS-6064. `ozone debug ldb` should print proper JSON with `--with-keys=true`

[GitBox <gi...@apache.org>]

sky76093016 commented on a change in pull request #2917:
URL: https://github.com/apache/ozone/pull/2917#discussion_r770191799



##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DBScanner.java
##########
@@ -61,8 +61,9 @@
   private String tableName;
 
   @CommandLine.Option(names = {"--with-keys"},
+      required = true,

Review comment:
       Thanks to @errose28 ’s review, I think it’s better to change `required` to `false` here. The purpose of using `false` is to allow users to make choices according to their needs. What do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org