You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "wernerdv (via GitHub)" <gi...@apache.org> on 2025/01/11 17:34:44 UTC
[PR] KAFKA-18479 Remove keepPartitionMetadataFile in UnifiedLog and LogMan… [kafka]
wernerdv opened a new pull request, #18491:
URL: https://github.com/apache/kafka/pull/18491
…ager
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18479: Remove keepPartitionMetadataFile in UnifiedLog and LogMan… [kafka]
Posted by "wernerdv (via GitHub)" <gi...@apache.org>.
wernerdv commented on PR #18491:
URL: https://github.com/apache/kafka/pull/18491#issuecomment-2585748900
@ijuma @junrao Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18479: Remove keepPartitionMetadataFile in UnifiedLog and LogMan… [kafka]
Posted by "junrao (via GitHub)" <gi...@apache.org>.
junrao merged PR #18491:
URL: https://github.com/apache/kafka/pull/18491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18479: Remove keepPartitionMetadataFile in UnifiedLog and LogMan… [kafka]
Posted by "junrao (via GitHub)" <gi...@apache.org>.
junrao commented on code in PR #18491:
URL: https://github.com/apache/kafka/pull/18491#discussion_r1915704367
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -190,40 +182,26 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Initialize topic ID information for the log by maintaining the partition metadata file and setting the in-memory _topicId.
- * Delete partition metadata file if the version does not support topic IDs.
Review Comment:
We can also remove the comment "topic IDs are supported" 2 lines below.
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -190,40 +182,26 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Initialize topic ID information for the log by maintaining the partition metadata file and setting the in-memory _topicId.
- * Delete partition metadata file if the version does not support topic IDs.
* Set _topicId based on a few scenarios:
* - Recover topic ID if present and topic IDs are supported. Ensure we do not try to assign a provided topicId that is inconsistent
* with the ID on file.
* - If we were provided a topic ID when creating the log, partition metadata files are supported, and one does not yet exist
* set _topicId and write to the partition metadata file.
- * - Otherwise set _topicId to None
Review Comment:
We can also remove the comment "partition metadata files are supported" 2 lines above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org