[GitHub] [openoffice] ardovm commented on a change in pull request #134: piecewise enabling of category b components

[GitBox <gi...@apache.org>]

ardovm commented on a change in pull request #134:
URL: https://github.com/apache/openoffice/pull/134#discussion_r704681323



##########
File path: main/configure.ac
##########
@@ -4392,7 +4449,7 @@ _ACEOF
           cat saxontest.java >&5
           AC_MSG_ERROR([saxontest could not be compiled, non-functional saxon jar])
         fi
-elif test "x$enable_saxon" = "xyes"; then
+elif test "x$enable_saxon" = "xyes" -a test "x$enable_saxon_explicit" != "xno"; then

Review comment:
       Instead of `(enable_saxon = yes) -a (enable_saxon_explicit != no)` it should rather be `(enable_saxon = yes) -a (disable_saxon_explicit != no)`
   
   In this patch, not indicating explicitly one setting is considered as disabling it explicitly.
   
   The previous implicit behavior is not preserved.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org