You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/09 07:52:04 UTC

[GitHub] [incubator-superset] kgabryje opened a new pull request #11212: refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab

kgabryje opened a new pull request #11212:
URL: https://github.com/apache/incubator-superset/pull/11212


   ### SUMMARY
   This PR re-reverts part of PR #11090 - it contains only changes in SqlLab, which were affected by the issue https://github.com/apache/incubator-superset/issues/11192 and https://github.com/apache/incubator-superset/issues/11191
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before/after:
   ![before](https://user-images.githubusercontent.com/15073128/94819147-34a98200-03ff-11eb-9b35-977785d0f510.gif)
   ![after](https://user-images.githubusercontent.com/15073128/94818835-d5e40880-03fe-11eb-9ce8-97b002f9df5b.gif)
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11212: refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11212:
URL: https://github.com/apache/incubator-superset/pull/11212#issuecomment-706033521


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=h1) Report
   > Merging [#11212](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/761e6dbf524acb1398d41297834a07430f21a050?el=desc) will **decrease** coverage by `0.41%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11212/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11212      +/-   ##
   ==========================================
   - Coverage   61.49%   61.08%   -0.42%     
   ==========================================
     Files         828      829       +1     
     Lines       39145    39182      +37     
     Branches     3589     3588       -1     
   ==========================================
   - Hits        24073    23933     -140     
   - Misses      14892    15069     +177     
     Partials      180      180              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.32% <ø> (+0.02%)` | :arrow_up: |
   | #python | `60.33% <ø> (-0.69%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/components/QueryHistory.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvUXVlcnlIaXN0b3J5LmpzeA==) | `50.00% <0.00%> (-33.34%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [...t/superset-frontend/src/common/components/Tabs.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tbW9uL2NvbXBvbmVudHMvVGFicy50c3g=) | `96.00% <0.00%> (-4.00%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.56% <0.00%> (-0.83%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvVGFiYmVkU3FsRWRpdG9ycy5qc3g=) | `72.07% <0.00%> (-0.65%)` | :arrow_down: |
   | ... and [4 more](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=footer). Last update [761e6db...4ae0f88](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #11212: refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab

Posted by GitBox <gi...@apache.org>.

mistercrunch commented on pull request #11212:
URL: https://github.com/apache/incubator-superset/pull/11212#issuecomment-708676555


   @kgabryje ^^^


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on pull request #11212: refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab

Posted by GitBox <gi...@apache.org>.

codecov-io commented on pull request #11212:
URL: https://github.com/apache/incubator-superset/pull/11212#issuecomment-706033521


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=h1) Report
   > Merging [#11212](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/761e6dbf524acb1398d41297834a07430f21a050?el=desc) will **increase** coverage by `0.83%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11212/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11212      +/-   ##
   ==========================================
   + Coverage   61.49%   62.32%   +0.83%     
   ==========================================
     Files         828      437     -391     
     Lines       39145    14627   -24518     
     Branches     3589     3588       -1     
   ==========================================
   - Hits        24073     9117   -14956     
   + Misses      14892     5330    -9562     
     Partials      180      180              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.32% <ø> (+0.02%)` | :arrow_up: |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/QueryHistory.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvUXVlcnlIaXN0b3J5LmpzeA==) | `50.00% <0.00%> (-33.34%)` | :arrow_down: |
   | [...t/superset-frontend/src/common/components/Tabs.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tbW9uL2NvbXBvbmVudHMvVGFicy50c3g=) | `96.00% <0.00%> (-4.00%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvVGFiYmVkU3FsRWRpdG9ycy5qc3g=) | `72.07% <0.00%> (-0.65%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvU291dGhQYW5lLmpzeA==) | `81.81% <0.00%> (ø)` | |
   | [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tbW9uL2NvbXBvbmVudHMvY29tbW9uLnN0b3JpZXMudHN4) | `0.00% <0.00%> (ø)` | |
   | [superset/commands/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | | |
   | [superset/migrations/versions/f231d82b9b26\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9mMjMxZDgyYjliMjZfLnB5) | | |
   | [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | | |
   | [...igrations/versions/763d4b211ec9\_fixing\_audit\_fk.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83NjNkNGIyMTFlYzlfZml4aW5nX2F1ZGl0X2ZrLnB5) | | |
   | ... and [388 more](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=footer). Last update [761e6db...4ae0f88](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11212: refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11212:
URL: https://github.com/apache/incubator-superset/pull/11212#issuecomment-706033521


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=h1) Report
   > Merging [#11212](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/761e6dbf524acb1398d41297834a07430f21a050?el=desc) will **increase** coverage by `4.10%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11212/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11212      +/-   ##
   ==========================================
   + Coverage   61.49%   65.60%   +4.10%     
   ==========================================
     Files         828      829       +1     
     Lines       39145    39185      +40     
     Branches     3589     3588       -1     
   ==========================================
   + Hits        24073    25707    +1634     
   + Misses      14892    13366    -1526     
   + Partials      180      112      -68     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.53% <ø> (?)` | |
   | #javascript | `62.32% <ø> (+0.02%)` | :arrow_up: |
   | #python | `61.01% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/QueryHistory.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvUXVlcnlIaXN0b3J5LmpzeA==) | `50.00% <0.00%> (-33.34%)` | :arrow_down: |
   | [...t/superset-frontend/src/common/components/Tabs.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tbW9uL2NvbXBvbmVudHMvVGFicy50c3g=) | `96.00% <0.00%> (-4.00%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvTGltaXRDb250cm9sLnRzeA==) | `84.78% <0.00%> (-1.89%)` | :arrow_down: |
   | [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGF0YXNvdXJjZS9DaGFuZ2VEYXRhc291cmNlTW9kYWwudHN4) | `73.21% <0.00%> (-1.34%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvU291dGhQYW5lLmpzeA==) | `81.81% <0.00%> (ø)` | |
   | [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tbW9uL2NvbXBvbmVudHMvY29tbW9uLnN0b3JpZXMudHN4) | `0.00% <0.00%> (ø)` | |
   | [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9MaXN0Vmlldy9UYWJsZUNvbGxlY3Rpb24udHN4) | `100.00% <0.00%> (ø)` | |
   | [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tbW9uL2NvbXBvbmVudHMvRHJvcGRvd24udHN4) | `100.00% <0.00%> (ø)` | |
   | [...set/superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2FjdGlvbnMvc3FsTGFiLmpz) | `60.25% <0.00%> (+0.64%)` | :arrow_up: |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvU3FsRWRpdG9yLmpzeA==) | `52.12% <0.00%> (+1.21%)` | :arrow_up: |
   | ... and [168 more](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=footer). Last update [761e6db...4ae0f88](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on pull request #11212: refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab

Posted by GitBox <gi...@apache.org>.

etr2460 commented on pull request #11212:
URL: https://github.com/apache/incubator-superset/pull/11212#issuecomment-708602448


   Note that this issue is still occuring with this fix: https://github.com/apache/incubator-superset/issues/11188


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] kgabryje commented on pull request #11212: refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab

Posted by GitBox <gi...@apache.org>.

kgabryje commented on pull request #11212:
URL: https://github.com/apache/incubator-superset/pull/11212#issuecomment-706031233


   @etr2460 @mistercrunch This PR fixes the issues raised by you (https://github.com/apache/incubator-superset/issues/11192 and https://github.com/apache/incubator-superset/issues/11191). Could you please take a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11212: refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11212:
URL: https://github.com/apache/incubator-superset/pull/11212#issuecomment-706033521


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=h1) Report
   > Merging [#11212](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/761e6dbf524acb1398d41297834a07430f21a050?el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11212/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11212      +/-   ##
   ==========================================
   + Coverage   61.49%   61.50%   +0.01%     
   ==========================================
     Files         828      829       +1     
     Lines       39145    39182      +37     
     Branches     3589     3588       -1     
   ==========================================
   + Hits        24073    24100      +27     
   - Misses      14892    14902      +10     
     Partials      180      180              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.32% <ø> (+0.02%)` | :arrow_up: |
   | #python | `61.01% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/QueryHistory.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvUXVlcnlIaXN0b3J5LmpzeA==) | `50.00% <0.00%> (-33.34%)` | :arrow_down: |
   | [...t/superset-frontend/src/common/components/Tabs.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tbW9uL2NvbXBvbmVudHMvVGFicy50c3g=) | `96.00% <0.00%> (-4.00%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvVGFiYmVkU3FsRWRpdG9ycy5qc3g=) | `72.07% <0.00%> (-0.65%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvU291dGhQYW5lLmpzeA==) | `81.81% <0.00%> (ø)` | |
   | [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tbW9uL2NvbXBvbmVudHMvY29tbW9uLnN0b3JpZXMudHN4) | `0.00% <0.00%> (ø)` | |
   | [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tbW9uL2NvbXBvbmVudHMvRHJvcGRvd24udHN4) | `100.00% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=footer). Last update [761e6db...4ae0f88](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on pull request #11212: refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab

Posted by GitBox <gi...@apache.org>.

codecov-io commented on pull request #11212:
URL: https://github.com/apache/incubator-superset/pull/11212#issuecomment-706033521


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=h1) Report
   > Merging [#11212](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/761e6dbf524acb1398d41297834a07430f21a050?el=desc) will **increase** coverage by `0.83%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11212/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11212      +/-   ##
   ==========================================
   + Coverage   61.49%   62.32%   +0.83%     
   ==========================================
     Files         828      437     -391     
     Lines       39145    14627   -24518     
     Branches     3589     3588       -1     
   ==========================================
   - Hits        24073     9117   -14956     
   + Misses      14892     5330    -9562     
     Partials      180      180              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.32% <ø> (+0.02%)` | :arrow_up: |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/QueryHistory.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvUXVlcnlIaXN0b3J5LmpzeA==) | `50.00% <0.00%> (-33.34%)` | :arrow_down: |
   | [...t/superset-frontend/src/common/components/Tabs.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tbW9uL2NvbXBvbmVudHMvVGFicy50c3g=) | `96.00% <0.00%> (-4.00%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvVGFiYmVkU3FsRWRpdG9ycy5qc3g=) | `72.07% <0.00%> (-0.65%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvU291dGhQYW5lLmpzeA==) | `81.81% <0.00%> (ø)` | |
   | [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tbW9uL2NvbXBvbmVudHMvY29tbW9uLnN0b3JpZXMudHN4) | `0.00% <0.00%> (ø)` | |
   | [superset/commands/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | | |
   | [superset/migrations/versions/f231d82b9b26\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9mMjMxZDgyYjliMjZfLnB5) | | |
   | [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | | |
   | [...igrations/versions/763d4b211ec9\_fixing\_audit\_fk.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83NjNkNGIyMTFlYzlfZml4aW5nX2F1ZGl0X2ZrLnB5) | | |
   | ... and [388 more](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=footer). Last update [761e6db...4ae0f88](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch merged pull request #11212: refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab

Posted by GitBox <gi...@apache.org>.

mistercrunch merged pull request #11212:
URL: https://github.com/apache/incubator-superset/pull/11212


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11212: refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11212:
URL: https://github.com/apache/incubator-superset/pull/11212#issuecomment-706033521






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11212: refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11212:
URL: https://github.com/apache/incubator-superset/pull/11212#issuecomment-706033521


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=h1) Report
   > Merging [#11212](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/761e6dbf524acb1398d41297834a07430f21a050?el=desc) will **increase** coverage by `4.25%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11212/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11212      +/-   ##
   ==========================================
   + Coverage   61.49%   65.74%   +4.25%     
   ==========================================
     Files         828      829       +1     
     Lines       39145    39185      +40     
     Branches     3589     3588       -1     
   ==========================================
   + Hits        24073    25763    +1690     
   + Misses      14892    13314    -1578     
   + Partials      180      108      -72     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `56.18% <ø> (?)` | |
   | #javascript | `62.32% <ø> (+0.02%)` | :arrow_up: |
   | #python | `61.01% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/QueryHistory.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvUXVlcnlIaXN0b3J5LmpzeA==) | `50.00% <0.00%> (-33.34%)` | :arrow_down: |
   | [...t/superset-frontend/src/common/components/Tabs.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tbW9uL2NvbXBvbmVudHMvVGFicy50c3g=) | `96.00% <0.00%> (-4.00%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvTGltaXRDb250cm9sLnRzeA==) | `84.78% <0.00%> (-1.89%)` | :arrow_down: |
   | [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGF0YXNvdXJjZS9DaGFuZ2VEYXRhc291cmNlTW9kYWwudHN4) | `73.21% <0.00%> (-1.34%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvU291dGhQYW5lLmpzeA==) | `81.81% <0.00%> (ø)` | |
   | [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tbW9uL2NvbXBvbmVudHMvY29tbW9uLnN0b3JpZXMudHN4) | `0.00% <0.00%> (ø)` | |
   | [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9MaXN0Vmlldy9UYWJsZUNvbGxlY3Rpb24udHN4) | `100.00% <0.00%> (ø)` | |
   | [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tbW9uL2NvbXBvbmVudHMvRHJvcGRvd24udHN4) | `100.00% <0.00%> (ø)` | |
   | [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvQWNlRWRpdG9yV3JhcHBlci50c3g=) | `60.75% <0.00%> (+1.26%)` | :arrow_up: |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2NvbXBvbmVudHMvZ3JpZENvbXBvbmVudHMvQ2hhcnRIb2xkZXIuanN4) | `79.16% <0.00%> (+1.38%)` | :arrow_up: |
   | ... and [170 more](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=footer). Last update [761e6db...4ae0f88](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11212: refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11212:
URL: https://github.com/apache/incubator-superset/pull/11212#issuecomment-706033521


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=h1) Report
   > Merging [#11212](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/761e6dbf524acb1398d41297834a07430f21a050?el=desc) will **decrease** coverage by `0.43%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11212/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11212      +/-   ##
   ==========================================
   - Coverage   61.49%   61.06%   -0.44%     
   ==========================================
     Files         828      829       +1     
     Lines       39145    39171      +26     
     Branches     3589     3588       -1     
   ==========================================
   - Hits        24073    23918     -155     
   - Misses      14892    15073     +181     
     Partials      180      180              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.32% <ø> (+0.02%)` | :arrow_up: |
   | #python | `60.30% <ø> (-0.72%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/components/QueryHistory.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvUXVlcnlIaXN0b3J5LmpzeA==) | `50.00% <0.00%> (-33.34%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [...t/superset-frontend/src/common/components/Tabs.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tbW9uL2NvbXBvbmVudHMvVGFicy50c3g=) | `96.00% <0.00%> (-4.00%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | ... and [12 more](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=footer). Last update [761e6db...4ae0f88](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11212: refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11212:
URL: https://github.com/apache/incubator-superset/pull/11212#issuecomment-706033521


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=h1) Report
   > Merging [#11212](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/761e6dbf524acb1398d41297834a07430f21a050?el=desc) will **decrease** coverage by `0.10%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11212/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11212      +/-   ##
   ==========================================
   - Coverage   61.49%   61.39%   -0.11%     
   ==========================================
     Files         828      829       +1     
     Lines       39145    39182      +37     
     Branches     3589     3588       -1     
   ==========================================
   - Hits        24073    24055      -18     
   - Misses      14892    14947      +55     
     Partials      180      180              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.32% <ø> (+0.02%)` | :arrow_up: |
   | #python | `60.83% <ø> (-0.19%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/QueryHistory.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvUXVlcnlIaXN0b3J5LmpzeA==) | `50.00% <0.00%> (-33.34%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
   | [...t/superset-frontend/src/common/components/Tabs.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tbW9uL2NvbXBvbmVudHMvVGFicy50c3g=) | `96.00% <0.00%> (-4.00%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvVGFiYmVkU3FsRWRpdG9ycy5qc3g=) | `72.07% <0.00%> (-0.65%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.12% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.70% <0.00%> (-0.14%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvU291dGhQYW5lLmpzeA==) | `81.81% <0.00%> (ø)` | |
   | [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tbW9uL2NvbXBvbmVudHMvY29tbW9uLnN0b3JpZXMudHN4) | `0.00% <0.00%> (ø)` | |
   | ... and [1 more](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=footer). Last update [761e6db...4ae0f88](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11212: refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11212:
URL: https://github.com/apache/incubator-superset/pull/11212#issuecomment-706033521


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=h1) Report
   > Merging [#11212](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/761e6dbf524acb1398d41297834a07430f21a050?el=desc) will **decrease** coverage by `0.45%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11212/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11212      +/-   ##
   ==========================================
   - Coverage   61.49%   61.04%   -0.46%     
   ==========================================
     Files         828      829       +1     
     Lines       39145    39171      +26     
     Branches     3589     3588       -1     
   ==========================================
   - Hits        24073    23911     -162     
   - Misses      14892    15080     +188     
     Partials      180      180              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.32% <ø> (+0.02%)` | :arrow_up: |
   | #python | `60.27% <ø> (-0.75%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/components/QueryHistory.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvUXVlcnlIaXN0b3J5LmpzeA==) | `50.00% <0.00%> (-33.34%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [...t/superset-frontend/src/common/components/Tabs.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tbW9uL2NvbXBvbmVudHMvVGFicy50c3g=) | `96.00% <0.00%> (-4.00%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.50% <0.00%> (-2.50%)` | :arrow_down: |
   | ... and [14 more](https://codecov.io/gh/apache/incubator-superset/pull/11212/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=footer). Last update [761e6db...4ae0f88](https://codecov.io/gh/apache/incubator-superset/pull/11212?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] kgabryje commented on pull request #11212: refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab

Posted by GitBox <gi...@apache.org>.

kgabryje commented on pull request #11212:
URL: https://github.com/apache/incubator-superset/pull/11212#issuecomment-706031233


   @etr2460 @mistercrunch This PR fixes the issues raised by you (https://github.com/apache/incubator-superset/issues/11192 and https://github.com/apache/incubator-superset/issues/11191). Could you please take a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org