[jira] Commented: (THRIFT-71) Debian packaging for thrift

["Anthony Molinaro (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901588#action_12901588 ] 

Anthony Molinaro commented on THRIFT-71:
----------------------------------------

Hi, I'm not a commiter for thrift, so take this as an opinion from the peanut gallery, and nothing more.

This patch looks like it puts a debian directory at the root of the thrift tree.  For the rpm spec file it's in the contrib directory, and looking back through the history of this it seems as though it was in contrib at some point and then pulled out.

However, I would question the placing of this in thrift at all.  Most distributions keep these files separate from the source code distribution.  For instance Redhat has their .spec files separate from all the software they package.  They don't try to keep the files with the package.  The problem with keeping these with the package is there is no one tasked with maintaining them.  Doesn't debian have a place where it keeps these packaging specific files?  Actually, looking at wikipedia it seems like there is a process for debian packaging http://en.wikipedia.org/wiki/Debian#Package_maintenance
and it seems like its usually the role of the maintainer of a debian package to take the upstream sources and build a package from them.  It does not and probably should not require the upstream package to contain packaging specific configuration.

Other than that, it seems like the problems with the distribution (ie, commons-lang and python unit test), were fixed and are no longer a problem.  So it should be fine for you to keep the debian packaging files wherever you would like and simply use them to build packages, letting the thrift developers know if they break something during the release cycle.

Alternatively, I think this could be added to contrib with the same guarantees on contrib as everything else which is no guarantees that
any of it works ever :)

Mostly up to the people maintaining the thrift source to decide.

> Debian packaging for thrift
> ---------------------------
>
>                 Key: THRIFT-71
>                 URL: https://issues.apache.org/jira/browse/THRIFT-71
>             Project: Thrift
>          Issue Type: Improvement
>         Environment: debian stable (etch); probably will work on lenny, but untested
>            Reporter: Eric Anderson
>            Priority: Minor
>         Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch, thrift-71_v6.patch, thrift-71_v7.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release.  It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests.  If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.