[GitHub] [incubator-opendal] tisonkun commented on a diff in pull request #3129: feat(binding/java): add behavior test framework for java

["tisonkun (via GitHub)" <gi...@apache.org>]

tisonkun commented on code in PR #3129:
URL: https://github.com/apache/incubator-opendal/pull/3129#discussion_r1332684919


##########
bindings/java/src/test/java/org/apache/opendal/OperatorTest.java:
##########
@@ -21,55 +21,175 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
-import java.nio.file.Path;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 import java.util.Arrays;
-import java.util.HashMap;
-import java.util.Map;
+import java.util.Optional;
+import java.util.UUID;
 import java.util.stream.Collectors;
-import lombok.Cleanup;
 import org.apache.opendal.condition.OpenDALExceptionCondition;
+import org.apache.opendal.utils.Utils;
+import org.junit.jupiter.api.AfterAll;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.io.TempDir;
 
 public class OperatorTest {
-    @TempDir
-    private static Path tempDir;
+
+    private static final String SCHEMA_KEY = "OPENDAL_TEST_SCHEMA";
+
+    protected static Optional<Operator> opOptional;
+
+    protected static Optional<BlockingOperator> blockingOpOptional;
+
+    @BeforeAll
+    public static void init() {
+        String schema = System.getProperty(SCHEMA_KEY);
+        assertTrue(schema != null && schema.length() > 0, () -> SCHEMA_KEY + " is not set");
+
+        opOptional = Utils.init(schema);
+
+        blockingOpOptional = Utils.initBlockingOp(schema);
+    }
+
+    @AfterAll
+    public static void clean() {
+        opOptional.ifPresent(op -> op.close());
+        blockingOpOptional.ifPresent(op -> op.close());
+    }
 
     @Test
-    public void testCreateAndDelete() {
-        Map<String, String> params = new HashMap<>();
-        params.put("root", "/tmp");
-        @Cleanup Operator op = new Operator("Memory", params);
-
-        op.write("testCreateAndDelete", "Odin").join();
-        assertThat(op.read("testCreateAndDelete").join()).isEqualTo("Odin");
-        op.delete("testCreateAndDelete").join();
-        assertThatThrownBy(() -> op.stat("testCreateAndDelete").join())
+    public void testBlockingWrite() {
+        if (!blockingOpOptional.isPresent()) {
+            return;
+        }
+        BlockingOperator blockingOp = blockingOpOptional.get();
+        Capability cap = blockingOp.info().fullCapability;
+        if (!cap.write || !cap.read) {
+            return;
+        }
+
+        String path = UUID.randomUUID().toString();
+        byte[] content = Utils.generateBytes();
+        blockingOp.write(path, content);
+
+        Metadata metadata = blockingOp.stat(path);
+
+        assertEquals(content.length, metadata.getContentLength());
+
+        blockingOp.delete(path);
+        assertThatThrownBy(() -> blockingOp.stat(path))
                 .is(OpenDALExceptionCondition.ofAsync(OpenDALException.Code.NotFound));
     }
 
     @Test
-    public void testAppendManyTimes() {
-        Map<String, String> params = new HashMap<>();
-        params.put("root", tempDir.toString());
-        @Cleanup Operator op = new Operator("fs", params);
+    public void testBlockingRead() {
+        if (!blockingOpOptional.isPresent()) {
+            return;
+        }
+        BlockingOperator blockingOp = blockingOpOptional.get();
+        Capability cap = blockingOp.info().fullCapability;
+        if (!cap.write || !cap.read) {
+            return;
+        }
+
+        Metadata metadata = blockingOp.stat("");
+        assertTrue(!metadata.isFile());
+
+        String path = UUID.randomUUID().toString();
+        assertThatThrownBy(() -> blockingOp.stat(path))
+                .is(OpenDALExceptionCondition.ofAsync(OpenDALException.Code.NotFound));
+
+        String content = Utils.generateString();

Review Comment:
   A fix is proposed at https://github.com/apache/incubator-opendal/pull/3153.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org