You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/12 10:35:09 UTC
[GitHub] [camel-kafka-connector] jakubmalek opened a new pull request, #1448: fix #1447 Fixed NPE error during SinkTask header mapping
jakubmalek opened a new pull request, #1448:
URL: https://github.com/apache/camel-kafka-connector/pull/1448
Fixed handling `SinkRecord` headers without schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] jakubmalek commented on a diff in pull request #1448: fix #1447 Fixed NPE error during SinkTask header mapping
Posted by GitBox <gi...@apache.org>.
jakubmalek commented on code in PR #1448:
URL: https://github.com/apache/camel-kafka-connector/pull/1448#discussion_r995802683
##########
parent/pom.xml:
##########
@@ -28,7 +28,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<kafka.version>2.8.0</kafka.version>
- <camel.version>3.19.0-SNAPSHOT</camel.version>
+ <camel.version>3.18.1</camel.version>
Review Comment:
This change is out of the scope of this PR, but it seems that CI build keeps failing with
```
Error: Failed to execute goal on project camel-aws-cloudwatch-sink-kafka-connector: Could not resolve dependencies for project org.apache.camel.kafkaconnector:camel-aws-cloudwatch-sink-kafka-connector:jar:3.19.0-SNAPSHOT: The following artifacts could not be resolved: org.apache.camel:camel-aws2-cw:jar:3.19.0-SNAPSHOT, org.apache.camel:camel-core:jar:3.19.0-SNAPSHOT, org.apache.camel:camel-yaml-dsl:jar:3.19.0-SNAPSHOT: Could not find artifact org.apache.camel:camel-aws2-cw:jar:3.19.0-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots/) -> [Help 1]
```
The version `3.19.0` doesn't work due to missing pom property `azure-jackson2-version`.
I also find it bit confusing to have version `3.19.0-SNAPSHOT` with parent [camel-dependencies](https://github.com/apache/camel-kafka-connector/blob/main/pom.xml#L26) v3.18.1.
Anyway I'm not that familiar with whole maven setup, I just wanted to check if it help pass the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] jakubmalek commented on pull request #1448: fix #1447 Fixed NPE error during SinkTask header mapping
Posted by GitBox <gi...@apache.org>.
jakubmalek commented on PR #1448:
URL: https://github.com/apache/camel-kafka-connector/pull/1448#issuecomment-1275952070
Issue reported at https://github.com/apache/camel-kafka-connector/issues/1447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on pull request #1448: fix #1447 Fixed NPE error during SinkTask header mapping
Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #1448:
URL: https://github.com/apache/camel-kafka-connector/pull/1448#issuecomment-1279064849
I need to.take a look at main. Don't worry your pr is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] jakubmalek commented on pull request #1448: fix #1447 Fixed NPE error during SinkTask header mapping
Posted by GitBox <gi...@apache.org>.
jakubmalek commented on PR #1448:
URL: https://github.com/apache/camel-kafka-connector/pull/1448#issuecomment-1278782510
The maven build seems to be failing resolving dependencies.
I've merged with upstream, I hope this time it will pass :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd merged pull request #1448: fix #1447 Fixed NPE error during SinkTask header mapping
Posted by GitBox <gi...@apache.org>.
oscerd merged PR #1448:
URL: https://github.com/apache/camel-kafka-connector/pull/1448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org