[GitHub] [eventmesh] mytang0 commented on a diff in pull request #3547: [Enhancement] Method manually handles closing an auto-closeable resource [MetricsHandler] #3009

["mytang0 (via GitHub)" <gi...@apache.org>]

mytang0 commented on code in PR #3547:
URL: https://github.com/apache/eventmesh/pull/3547#discussion_r1152649875


##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/HTTPClientHandler.java:
##########
@@ -95,7 +95,8 @@ void delete(HttpExchange httpExchange) throws IOException {
             Error error = new Error(e.toString(), stackTrace);
             String result = JsonUtils.toJSONString(error);
             httpExchange.sendResponseHeaders(500, result.getBytes().length);

Review Comment:
   Please help simplify, replace with 'httpExchange.sendResponseHeaders(500,  0);'



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org