You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "dariuszseweryn (via GitHub)" <gi...@apache.org> on 2025/03/10 12:37:42 UTC
[PR] NIFI-14347 Update Kinesis Client Library to 3.0.1 [nifi]
dariuszseweryn opened a new pull request, #9790:
URL: https://github.com/apache/nifi/pull/9790
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-14347](https://issues.apache.org/jira/browse/NIFI-14347)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-14347`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-14347`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [x] Build completed using `mvn clean install -P contrib-check`
- [x] JDK 21
### Licensing
- [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [x] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14347 Update Kinesis Client Library to 3.0.1 [nifi]
Posted by "dariuszseweryn (via GitHub)" <gi...@apache.org>.
dariuszseweryn commented on code in PR #9790:
URL: https://github.com/apache/nifi/pull/9790#discussion_r2012322446
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/kinesis/stream/ConsumeKinesisStream.java:
##########
@@ -652,7 +652,9 @@ synchronized Scheduler prepareScheduler(final ProcessContext context, final Proc
final LeaseManagementConfig leaseManagementConfig = configsBuilder.leaseManagementConfig()
.failoverTimeMillis(getFailoverTimeMillis(context))
.streamName(streamName);
- final CoordinatorConfig coordinatorConfig = configsBuilder.coordinatorConfig().workerStateChangeListener(workerState::set);
+ final CoordinatorConfig coordinatorConfig = configsBuilder.coordinatorConfig()
+ .workerStateChangeListener(workerState::set)
+ .clientVersionConfig(CoordinatorConfig.ClientVersionConfig.CLIENT_VERSION_CONFIG_COMPATIBLE_WITH_2X);
Review Comment:
It should be possible but I don't have the bandwidth now to investigate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14347 Update Kinesis Client Library to 3.0.1 [nifi]
Posted by "dariuszseweryn (via GitHub)" <gi...@apache.org>.
dariuszseweryn commented on PR #9790:
URL: https://github.com/apache/nifi/pull/9790#issuecomment-2751610831
While I totally like the idea of the processor automatically determine if migration is necessary I don't have time at the moment to pursue that route.
I'll close this PR now and potentially revisit later on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14347 Update Kinesis Client Library to 3.0.1 [nifi]
Posted by "dariuszseweryn (via GitHub)" <gi...@apache.org>.
dariuszseweryn closed pull request #9790: NIFI-14347 Update Kinesis Client Library to 3.0.1
URL: https://github.com/apache/nifi/pull/9790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14347 Update Kinesis Client Library to 3.0.1 [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on code in PR #9790:
URL: https://github.com/apache/nifi/pull/9790#discussion_r1987413795
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/kinesis/stream/ConsumeKinesisStream.java:
##########
@@ -652,7 +652,9 @@ synchronized Scheduler prepareScheduler(final ProcessContext context, final Proc
final LeaseManagementConfig leaseManagementConfig = configsBuilder.leaseManagementConfig()
.failoverTimeMillis(getFailoverTimeMillis(context))
.streamName(streamName);
- final CoordinatorConfig coordinatorConfig = configsBuilder.coordinatorConfig().workerStateChangeListener(workerState::set);
+ final CoordinatorConfig coordinatorConfig = configsBuilder.coordinatorConfig()
+ .workerStateChangeListener(workerState::set)
+ .clientVersionConfig(CoordinatorConfig.ClientVersionConfig.CLIENT_VERSION_CONFIG_COMPATIBLE_WITH_2X);
Review Comment:
Is there a way to check the current status of the Kinesis stream to determine whether this compatibility flag is needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org