[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9586: [mypy] Enforcing typing for a number of modules

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #9586:
URL: https://github.com/apache/incubator-superset/pull/9586#discussion_r412030951



##########
File path: superset/utils/core.py
##########
@@ -1064,8 +1064,8 @@ def get_since_until(
             since, until = time_range.split(separator, 1)
             if since and since not in common_time_frames:
                 since = add_ago_to_since(since)
-            since = parse_human_datetime(since)
-            until = parse_human_datetime(until)
+            since = parse_human_datetime(since)  # type: ignore

Review comment:
       Agree, we could use a different variable here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org