You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by misakuo <gi...@git.apache.org> on 2017/03/30 08:34:16 UTC
[GitHub] incubator-weex pull request #191: * [android] prevent the NullPointerExcepti...
GitHub user misakuo opened a pull request:
https://github.com/apache/incubator-weex/pull/191
* [android] prevent the NullPointerException
prevent the NPE that caused by WXSDKInstance object is null
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/misakuo/incubator-weex android-bugfix-instance-npe
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/191.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #191
----
commit 7f606216b1b6239749c56100d65f1d067ff9e9fd
Author: moxun.ljf <mo...@alibaba-inc.com>
Date: 2017-03-23T05:45:38Z
* [example] add demo for list & scroller with onScroll event
commit 9076095f84cbc8b886ecba10ec8a74d70ad92d8e
Author: moxun.ljf <fu...@foxmail.com>
Date: 2017-03-27T02:53:23Z
Merge remote-tracking branch 'upstream/0.12-dev' into 0.12-dev
commit e7656e791af8da09bb39c8f96af4e00daa6ad1d2
Author: moxun.ljf <fu...@foxmail.com>
Date: 2017-03-27T11:46:10Z
Merge remote-tracking branch 'upstream/0.12-dev' into 0.12-dev
commit 8f62317a2edb67f972f6e7cfb84a1ed9182b4b87
Author: moxun.ljf <fu...@foxmail.com>
Date: 2017-03-30T08:19:24Z
Merge remote-tracking branch 'upstream/0.12-dev' into 0.12-dev
# Conflicts:
# examples/component/list/list-basic.we
commit bfb99d2c30d21429385965fd78d95b3f8b7aae1a
Author: moxun.ljf <fu...@foxmail.com>
Date: 2017-03-30T08:30:53Z
* [android] prevent NPE that caused by WXSDKInstance is null
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #191: * [android] prevent the NullPointerExcepti...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/191
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #191: * [android] prevent the NullPointerExcepti...
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/191#discussion_r110369848
--- Diff: android/sdk/src/main/java/com/taobao/weex/WXSDKManager.java ---
@@ -218,7 +218,11 @@ public static WXSDKManager getInstance() {
}
public static int getInstanceViewPortWidth(String instanceId){
- return getInstance().getSDKInstance(instanceId).getInstanceViewPortWidth();
+ WXSDKInstance instance = getInstance().getSDKInstance(instanceId);
+ if (instance == null) {
+ return 750;
--- End diff --
Use a constant instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #191: * [android] prevent the NullPointerException
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/191
<!--
0 failure:
1 warning: Potential BREAK C...
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/WXSDKManager.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---