[GitHub] [flink] dianfu commented on a change in pull request #12870: [FLINK-18491][python] Extract the implementation logic of Beam in coders

[GitBox <gi...@apache.org>]

dianfu commented on a change in pull request #12870:
URL: https://github.com/apache/flink/pull/12870#discussion_r454080679



##########
File path: flink-python/pyflink/fn_execution/tests/test_process_mode_boot.py
##########
@@ -126,7 +126,10 @@ def test_set_working_directory(self):
         fn_execution_dir = os.path.join(pyflink_dir, "fn_execution")
         os.mkdir(fn_execution_dir)
         open(os.path.join(fn_execution_dir, "__init__.py"), 'a').close()
-        with open(os.path.join(fn_execution_dir, "boot.py"), "w") as f:
+        beam_dir = os.path.join(fn_execution_dir, "beam")
+        os.mkdir(beam_dir)

Review comment:
       what's the purpose of these two lines:
   ```
   os.mkdir(beam_dir)
   open(os.path.join(beam_dir, "__init__.py"), 'a').close()
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org