You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "nausharipov (via GitHub)" <gi...@apache.org> on 2023/02/02 09:52:02 UTC
[GitHub] [beam] nausharipov commented on a diff in pull request #25254: Playground Frontend Test workflow (#24728)
nausharipov commented on code in PR #25254:
URL: https://github.com/apache/beam/pull/25254#discussion_r1094267471
##########
.github/workflows/playground_frontend_test.yml:
##########
@@ -0,0 +1,91 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Playground Frontend Test
+
+on:
+ push:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ pull_request:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+jobs:
+ playground_frontend_test:
+ name: Playground Frontend Test
+ runs-on: ubuntu-latest
+
+ env:
+ FLUTTER_VERSION: '3.3.2'
Review Comment:
Is it the single source of truth for the project's Flutter version? Should it be stored here?
##########
.github/workflows/playground_frontend_test.yml:
##########
@@ -0,0 +1,91 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Playground Frontend Test
+
+on:
+ push:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ pull_request:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+jobs:
+ playground_frontend_test:
+ name: Playground Frontend Test
+ runs-on: ubuntu-latest
+
+ env:
+ FLUTTER_VERSION: '3.3.2'
+
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: 'Cache Flutter Dependencies'
+ uses: actions/cache@v3
+ with:
+ path: /opt/hostedtoolcache/flutter
+ key: ${{ runner.OS }}-flutter-install-cache-${{ env.FLUTTER_VERSION }}
+ restore-keys: ${{ runner.OS }}-flutter-install-cache
+
+ - uses: subosito/flutter-action@v2
+ with:
+ flutter-version: ${{ env.FLUTTER_VERSION }}
+ channel: 'stable'
+
+ - name: 'Install Dependencies'
+ working-directory: playground/frontend
+ run: |
+ cd playground_components && flutter pub get && cd ..
+ cd playground_components_dev && flutter pub get && cd ..
+ flutter pub get
+
+# - name: 'Formatting'
Review Comment:
Maybe delete the comments?
##########
.github/workflows/playground_frontend_test.yml:
##########
@@ -0,0 +1,91 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Playground Frontend Test
+
+on:
+ push:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ pull_request:
+ paths: ['playground/frontend/**']
+ branches: ['**']
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true
+
+jobs:
+ playground_frontend_test:
+ name: Playground Frontend Test
+ runs-on: ubuntu-latest
+
+ env:
+ FLUTTER_VERSION: '3.3.2'
+
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: 'Cache Flutter Dependencies'
+ uses: actions/cache@v3
+ with:
+ path: /opt/hostedtoolcache/flutter
+ key: ${{ runner.OS }}-flutter-install-cache-${{ env.FLUTTER_VERSION }}
+ restore-keys: ${{ runner.OS }}-flutter-install-cache
+
+ - uses: subosito/flutter-action@v2
+ with:
+ flutter-version: ${{ env.FLUTTER_VERSION }}
+ channel: 'stable'
+
+ - name: 'Install Dependencies'
+ working-directory: playground/frontend
+ run: |
+ cd playground_components && flutter pub get && cd ..
+ cd playground_components_dev && flutter pub get && cd ..
+ flutter pub get
+
+# - name: 'Formatting'
+# run: dart format --output=none --set-exit-if-changed .
+
+# - name: 'Analyze playground_components'
+# working-directory: playground/frontend/playground_components
+# run: dart analyze --fatal-infos
+
+# - name: 'Analyze playground_components_dev'
+# working-directory: playground/frontend/playground_components_dev
+# run: dart analyze --fatal-infos
+
+# - name: 'Analyze playground'
+# working-directory: playground/frontend
+# run: dart analyze --fatal-infos lib test
+
+ - name: 'Test playground_components'
+ working-directory: playground/frontend/playground_components
+ run: flutter test
+
+ - name: 'Test playground'
Review Comment:
Will ToB need such workflow? If so, should the project name be mentioned in the job names?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org