You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/11/28 04:16:35 UTC
[GitHub] [incubator-hugegraph-computer] seagle-yuan opened a new pull request, #208: dist pom add k8s-operator,yarn,algorithm dependencies & delete redundance license
seagle-yuan opened a new pull request, #208:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/208
dist pom add k8s-operator,yarn,algorithm dependencies & delete redundance license
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-computer] coderzc commented on a diff in pull request #208: dist pom add k8s-operator,yarn,algorithm dependencies & delete redundance license
Posted by GitBox <gi...@apache.org>.
coderzc commented on code in PR #208:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/208#discussion_r1033114662
##########
computer-dist/pom.xml:
##########
@@ -53,11 +35,27 @@
</properties>
<dependencies>
+
+ <dependency>
+ <groupId>org.apache.hugegraph</groupId>
+ <artifactId>computer-algorithm</artifactId>
+ </dependency>
+
<dependency>
<groupId>org.apache.hugegraph</groupId>
<artifactId>computer-core</artifactId>
- <version>${revision}</version>
</dependency>
+
+ <dependency>
+ <groupId>org.apache.hugegraph</groupId>
+ <artifactId>computer-k8s-operator</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.hugegraph</groupId>
+ <artifactId>computer-yarn</artifactId>
+ </dependency>
+
Review Comment:
Use `provided` scope?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-computer] imbajin merged pull request #208: chore: add k8s-operator,yarn,algorithm dependencies & delete redundance license
Posted by GitBox <gi...@apache.org>.
imbajin merged PR #208:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-computer] codecov[bot] commented on pull request #208: dist pom add k8s-operator,yarn,algorithm dependencies & delete redundance license
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #208:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/208#issuecomment-1328529100
# [Codecov](https://codecov.io/gh/apache/incubator-hugegraph-computer/pull/208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#208](https://codecov.io/gh/apache/incubator-hugegraph-computer/pull/208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9b8dcc5) into [master](https://codecov.io/gh/apache/incubator-hugegraph-computer/commit/a63cec16c940a8953e983fa9a8b3957c4ed22ed5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a63cec1) will **increase** coverage by `0.11%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #208 +/- ##
============================================
+ Coverage 85.70% 85.81% +0.11%
- Complexity 3229 3233 +4
============================================
Files 344 344
Lines 12079 12079
Branches 1087 1087
============================================
+ Hits 10352 10366 +14
+ Misses 1202 1188 -14
Partials 525 525
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hugegraph-computer/pull/208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/hugegraph/computer/core/bsp/EtcdClient.java](https://codecov.io/gh/apache/incubator-hugegraph-computer/pull/208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tcHV0ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2NvbXB1dGVyL2NvcmUvYnNwL0V0Y2RDbGllbnQuamF2YQ==) | `72.81% <0.00%> (+0.92%)` | :arrow_up: |
| [...k8s/operator/controller/ComputerJobController.java](https://codecov.io/gh/apache/incubator-hugegraph-computer/pull/208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tcHV0ZXItazhzLW9wZXJhdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWdlZ3JhcGgvY29tcHV0ZXIvazhzL29wZXJhdG9yL2NvbnRyb2xsZXIvQ29tcHV0ZXJKb2JDb250cm9sbGVyLmphdmE=) | `90.06% <0.00%> (+1.36%)` | :arrow_up: |
| [.../hugegraph/computer/core/worker/WorkerService.java](https://codecov.io/gh/apache/incubator-hugegraph-computer/pull/208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tcHV0ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2NvbXB1dGVyL2NvcmUvd29ya2VyL1dvcmtlclNlcnZpY2UuamF2YQ==) | `90.47% <0.00%> (+2.38%)` | :arrow_up: |
| [...che/hugegraph/computer/core/util/ShutdownHook.java](https://codecov.io/gh/apache/incubator-hugegraph-computer/pull/208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tcHV0ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2NvbXB1dGVyL2NvcmUvdXRpbC9TaHV0ZG93bkhvb2suamF2YQ==) | `66.66% <0.00%> (+22.22%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org