You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/01/14 13:34:59 UTC
[GitHub] [openwhisk] sven-lange-last opened a new pull request #4799: Change
absolute to relative file references
sven-lange-last opened a new pull request #4799: Change absolute to relative file references
URL: https://github.com/apache/openwhisk/pull/4799
With this change, the standalone project build uses relative paths instead of absolute paths starting from the root project. With these relative paths, the standalone project can be built as sub-project of different root projects.
Co-authored-by: Georg Bildhauer <bi...@de.ibm.com>
## Description
<!--- Provide a detailed description of your changes. -->
<!--- Include details of what problem you are solving and how your changes are tested. -->
With the current usage of `project.rootProject.getProjectDir()` in Gradle build files, the standalone project can no more be built when imported by another Gradle project. This is fixed by changing all references to relative references.
## Related issue and scope
<!--- Please include a link to a related issue if there is one. -->
- [ ] I opened an issue to propose and discuss this change (#????)
## My changes affect the following components
<!--- Select below all system components are affected by your change. -->
<!--- Enter an `x` in all applicable boxes. -->
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [ ] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
- [x] Standalone
## Types of changes
<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
- [ ] Bug fix (generally a non-breaking change which closes an issue).
- [x] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
This is not really a bug fix but a small enhancement that should not change any existing behavior. Only a slight change in the build strategy.
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [x] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] sven-lange-last edited a comment on issue #4799: Change
absolute to relative file references
Posted by GitBox <gi...@apache.org>.
sven-lange-last edited a comment on issue #4799: Change absolute to relative file references
URL: https://github.com/apache/openwhisk/pull/4799#issuecomment-574188050
@rabbah good question - I didn't try to override the project. I looked up how other projects solve the same problem - for example...
https://github.com/apache/openwhisk/blob/165d9579764697d33919ce850c9613de2719b4cf/core/invoker/build.gradle#L33
Property `project.rootProject` is documented to be read-only. I guess it cannot be changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] sven-lange-last edited a comment on issue #4799: Change
absolute to relative file references
Posted by GitBox <gi...@apache.org>.
sven-lange-last edited a comment on issue #4799: Change absolute to relative file references
URL: https://github.com/apache/openwhisk/pull/4799#issuecomment-574178243
PG 1 / 380 running...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] mhenke1 merged pull request #4799: Change absolute to
relative file references
Posted by GitBox <gi...@apache.org>.
mhenke1 merged pull request #4799: Change absolute to relative file references
URL: https://github.com/apache/openwhisk/pull/4799
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] sven-lange-last commented on issue #4799: Change
absolute to relative file references
Posted by GitBox <gi...@apache.org>.
sven-lange-last commented on issue #4799: Change absolute to relative file references
URL: https://github.com/apache/openwhisk/pull/4799#issuecomment-574188050
@rabbah good question - I didn't try to override the project. I looked up how other projects solve the same problem - for example...
https://github.com/apache/openwhisk/blob/165d9579764697d33919ce850c9613de2719b4cf/core/invoker/build.gradle#L33
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] sven-lange-last commented on issue #4799: Change
absolute to relative file references
Posted by GitBox <gi...@apache.org>.
sven-lange-last commented on issue #4799: Change absolute to relative file references
URL: https://github.com/apache/openwhisk/pull/4799#issuecomment-574178243
PG 1 / 379 running...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services