You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/07/16 20:45:53 UTC
[GitHub] [cordova-plugin-device] selmo47 opened a new pull request #126: GH-91 android: Implement the changes in getting serial (Api_level 26):
selmo47 opened a new pull request #126:
URL: https://github.com/apache/cordova-plugin-device/pull/126
* get the serial according to the Api_level:
+ if Api_level < 26:
=> android.os.Build.SERIAL (deprecated in Api_level 26)
+ else:
=> serial = android.os.Build.getSerial(); (introduced in 26)
* add the appropriate permissions:
+ READ_PHONE_STATE
+ READ_PRIVILEGED_PHONE_STATE
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-device] breautek closed pull request #126: GH-91 android: Implement the changes in getting serial (Api_level 26):
Posted by GitBox <gi...@apache.org>.
breautek closed pull request #126:
URL: https://github.com/apache/cordova-plugin-device/pull/126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-device] breautek commented on a change in pull request #126: GH-91 android: Implement the changes in getting serial (Api_level 26):
Posted by GitBox <gi...@apache.org>.
breautek commented on a change in pull request #126:
URL: https://github.com/apache/cordova-plugin-device/pull/126#discussion_r456070547
##########
File path: plugin.xml
##########
@@ -37,10 +37,14 @@
<!-- android -->
<platform name="android">
<config-file target="res/xml/config.xml" parent="/*">
- <feature name="Device" >
+ <feature name="Device">
<param name="android-package" value="org.apache.cordova.device.Device"/>
</feature>
</config-file>
+ <config-file target="AndroidManifest.xml" parent="/*">
+ <uses-permission android:name="android.permission.READ_PHONE_STATE"/>
+ <uses-permission android:name="android.permission.READ_PRIVILEGED_PHONE_STATE"/>
Review comment:
Cordova cannot define privileged permissions because that would cause apps to be rejected from the Google Play store.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-device] breautek commented on pull request #126: GH-91 android: Implement the changes in getting serial (Api_level 26):
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #126:
URL: https://github.com/apache/cordova-plugin-device/pull/126#issuecomment-923095280
Closing this PR because obtaining the Serial / uuid (as well as any other non-resettable identifier) is no longer possible without privileged permissions.
https://github.com/apache/cordova-plugin-device/issues/111#issuecomment-923089570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-device] Legenyes commented on pull request #126: GH-91 android: Implement the changes in getting serial (Api_level 26):
Posted by GitBox <gi...@apache.org>.
Legenyes commented on pull request #126:
URL: https://github.com/apache/cordova-plugin-device/pull/126#issuecomment-802764161
Up ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org