You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/19 04:56:57 UTC

[GitHub] [flink] pyscala opened a new pull request #13680: [FLINK-19553] The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss

pyscala opened a new pull request #13680:
URL: https://github.com/apache/flink/pull/13680


   
   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss
   
   ## Brief change log
   change the following format from 'HH:mm:ss' to 'yyyy-MM-dd HH:mm:ss'
   Latest Completed Checkpoint:Completion Time
   Latest Failed Checkpoint:Failure Time
   Latest Savepoint:Completion Time
   Latest Restore:Restore Time
   
   ## Verifying this change
   
   This change was tested in locally.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pyscala commented on pull request #13680: [FLINK-19553] [ Runtime / Web Frontend] The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss

Posted by GitBox <gi...@apache.org>.
pyscala commented on pull request #13680:
URL: https://github.com/apache/flink/pull/13680#issuecomment-713257351


   > Thanks for your update, I think we should also include date information for trigger timestamp, please update related code and offer the updated UI with your new changes.
   
   @Myasuka Thanks for your reply. We have the same views and I will finish it as soon as possible.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pyscala commented on pull request #13680: [FLINK-19553] [ Runtime / Web Frontend] The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss

Posted by GitBox <gi...@apache.org>.
pyscala commented on pull request #13680:
URL: https://github.com/apache/flink/pull/13680#issuecomment-713305996


   ![image](https://user-images.githubusercontent.com/20840332/96675769-3e8b2900-139e-11eb-99ea-c624457d0b1b.png)
   @Myasuka Done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13680: [FLINK-19553] [ Runtime / Web Frontend] The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13680:
URL: https://github.com/apache/flink/pull/13680#issuecomment-711566687


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit c4b66492f144a96a1ea793149162b2ef29441f8f (Mon Oct 19 04:59:30 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Myasuka commented on pull request #13680: [FLINK-19553] [ Runtime / Web Frontend] The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss

Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #13680:
URL: https://github.com/apache/flink/pull/13680#issuecomment-716528990


   @pyscala Before I merge this PR, could you merge your commits as single one and rename the title as `[FLINK-19553][web] Make timestamp of checkpoints shown with date format`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Myasuka merged pull request #13680: [FLINK-19553][web] Make timestamp of checkpoints shown with date format

Posted by GitBox <gi...@apache.org>.
Myasuka merged pull request #13680:
URL: https://github.com/apache/flink/pull/13680


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Myasuka commented on pull request #13680: [FLINK-19553] [ Runtime / Web Frontend] The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss

Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #13680:
URL: https://github.com/apache/flink/pull/13680#issuecomment-711770401


   @pyscala Thanks for your contribution. Could you please paste the new web UI pictures here if applied your changes?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13680: [FLINK-19553] [ Runtime / Web Frontend] The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13680:
URL: https://github.com/apache/flink/pull/13680#issuecomment-711592132


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c4b66492f144a96a1ea793149162b2ef29441f8f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7832",
       "triggerID" : "c4b66492f144a96a1ea793149162b2ef29441f8f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9085414f0bcc7644d623260bdf50758046f95fd",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7887",
       "triggerID" : "f9085414f0bcc7644d623260bdf50758046f95fd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a040eaf5fdc1858602290024370747ee7d2c8e13",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7979",
       "triggerID" : "a040eaf5fdc1858602290024370747ee7d2c8e13",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f9085414f0bcc7644d623260bdf50758046f95fd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7887) 
   * a040eaf5fdc1858602290024370747ee7d2c8e13 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7979) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13680: [FLINK-19553] [ Runtime / Web Frontend] The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13680:
URL: https://github.com/apache/flink/pull/13680#issuecomment-711592132


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c4b66492f144a96a1ea793149162b2ef29441f8f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7832",
       "triggerID" : "c4b66492f144a96a1ea793149162b2ef29441f8f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c4b66492f144a96a1ea793149162b2ef29441f8f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7832) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pyscala commented on pull request #13680: [FLINK-19553] [ Runtime / Web Frontend] The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss

Posted by GitBox <gi...@apache.org>.
pyscala commented on pull request #13680:
URL: https://github.com/apache/flink/pull/13680#issuecomment-711929565


   > Thanks for your update!
   > 
   > I think we should also update the timestamp format in `job-checkpoints-detail.component.html` and `job-checkpoints-subtask.component.html` except your current changes. Please update the pictures withe new changes.
   
   @Myasuka Sounds good to me. I will do it later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13680: [FLINK-19553] [ Runtime / Web Frontend] The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13680:
URL: https://github.com/apache/flink/pull/13680#issuecomment-711592132


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c4b66492f144a96a1ea793149162b2ef29441f8f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7832",
       "triggerID" : "c4b66492f144a96a1ea793149162b2ef29441f8f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9085414f0bcc7644d623260bdf50758046f95fd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f9085414f0bcc7644d623260bdf50758046f95fd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c4b66492f144a96a1ea793149162b2ef29441f8f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7832) 
   * f9085414f0bcc7644d623260bdf50758046f95fd UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13680: [FLINK-19553] [ Runtime / Web Frontend] The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13680:
URL: https://github.com/apache/flink/pull/13680#issuecomment-711592132


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c4b66492f144a96a1ea793149162b2ef29441f8f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7832",
       "triggerID" : "c4b66492f144a96a1ea793149162b2ef29441f8f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c4b66492f144a96a1ea793149162b2ef29441f8f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7832) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13680: [FLINK-19553] [ Runtime / Web Frontend] The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13680:
URL: https://github.com/apache/flink/pull/13680#issuecomment-711592132


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c4b66492f144a96a1ea793149162b2ef29441f8f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7832",
       "triggerID" : "c4b66492f144a96a1ea793149162b2ef29441f8f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9085414f0bcc7644d623260bdf50758046f95fd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7887",
       "triggerID" : "f9085414f0bcc7644d623260bdf50758046f95fd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a040eaf5fdc1858602290024370747ee7d2c8e13",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7979",
       "triggerID" : "a040eaf5fdc1858602290024370747ee7d2c8e13",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a040eaf5fdc1858602290024370747ee7d2c8e13 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7979) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13680: [FLINK-19553][web] Make timestamp of checkpoints shown with date format

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13680:
URL: https://github.com/apache/flink/pull/13680#issuecomment-711592132


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c4b66492f144a96a1ea793149162b2ef29441f8f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7832",
       "triggerID" : "c4b66492f144a96a1ea793149162b2ef29441f8f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9085414f0bcc7644d623260bdf50758046f95fd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7887",
       "triggerID" : "f9085414f0bcc7644d623260bdf50758046f95fd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a040eaf5fdc1858602290024370747ee7d2c8e13",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7979",
       "triggerID" : "a040eaf5fdc1858602290024370747ee7d2c8e13",
       "triggerType" : "PUSH"
     }, {
       "hash" : "746d30c0758aa6b5f80cf826f084780a33a57de0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "746d30c0758aa6b5f80cf826f084780a33a57de0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a040eaf5fdc1858602290024370747ee7d2c8e13 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7979) 
   * 746d30c0758aa6b5f80cf826f084780a33a57de0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13680: [FLINK-19553] [ Runtime / Web Frontend] The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13680:
URL: https://github.com/apache/flink/pull/13680#issuecomment-711592132


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c4b66492f144a96a1ea793149162b2ef29441f8f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c4b66492f144a96a1ea793149162b2ef29441f8f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c4b66492f144a96a1ea793149162b2ef29441f8f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pyscala commented on pull request #13680: [FLINK-19553] [ Runtime / Web Frontend] The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss

Posted by GitBox <gi...@apache.org>.
pyscala commented on pull request #13680:
URL: https://github.com/apache/flink/pull/13680#issuecomment-711855408


   > @pyscala Thanks for your contribution. Could you please paste the new web UI pictures here if applied your changes?
   
   @Myasuka of course. Thanks for your reply.
   ![image](https://user-images.githubusercontent.com/20840332/96421489-6b69ff80-1229-11eb-982b-ee29e84df0d7.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pyscala commented on pull request #13680: [FLINK-19553] [ Runtime / Web Frontend] The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss

Posted by GitBox <gi...@apache.org>.
pyscala commented on pull request #13680:
URL: https://github.com/apache/flink/pull/13680#issuecomment-711958207


   ![image](https://user-images.githubusercontent.com/20840332/96429532-9eb18c00-1233-11eb-94e0-67a67262ceae.png)
   @Myasuka What do you think of ? Do the timestamp format of Trigger Timestamp and Latest Acknowledgement need to be changed?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pyscala commented on pull request #13680: [FLINK-19553] [ Runtime / Web Frontend] The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss

Posted by GitBox <gi...@apache.org>.
pyscala commented on pull request #13680:
URL: https://github.com/apache/flink/pull/13680#issuecomment-712541125


   ![image](https://user-images.githubusercontent.com/20840332/96531171-99981f80-12bb-11eb-946c-41c26a2b88f7.png)
   @Myasuka Done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pyscala commented on pull request #13680: [FLINK-19553] [ Runtime / Web Frontend] The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss

Posted by GitBox <gi...@apache.org>.
pyscala commented on pull request #13680:
URL: https://github.com/apache/flink/pull/13680#issuecomment-716928020


   > @pyscala Before I merge this PR, could you merge your commits as single one and rename the title as `[FLINK-19553][web] Make timestamp of checkpoints shown with date format`?
   
   @Myasuka Sure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13680: [FLINK-19553] [ Runtime / Web Frontend] The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13680:
URL: https://github.com/apache/flink/pull/13680#issuecomment-711592132


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c4b66492f144a96a1ea793149162b2ef29441f8f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7832",
       "triggerID" : "c4b66492f144a96a1ea793149162b2ef29441f8f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9085414f0bcc7644d623260bdf50758046f95fd",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7887",
       "triggerID" : "f9085414f0bcc7644d623260bdf50758046f95fd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a040eaf5fdc1858602290024370747ee7d2c8e13",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a040eaf5fdc1858602290024370747ee7d2c8e13",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f9085414f0bcc7644d623260bdf50758046f95fd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7887) 
   * a040eaf5fdc1858602290024370747ee7d2c8e13 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13680: [FLINK-19553] [ Runtime / Web Frontend] The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13680:
URL: https://github.com/apache/flink/pull/13680#issuecomment-711592132


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c4b66492f144a96a1ea793149162b2ef29441f8f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7832",
       "triggerID" : "c4b66492f144a96a1ea793149162b2ef29441f8f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9085414f0bcc7644d623260bdf50758046f95fd",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7887",
       "triggerID" : "f9085414f0bcc7644d623260bdf50758046f95fd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c4b66492f144a96a1ea793149162b2ef29441f8f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7832) 
   * f9085414f0bcc7644d623260bdf50758046f95fd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7887) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13680: [FLINK-19553] [ Runtime / Web Frontend] The format of checkpoint Completion Time and Failure Time should be changed from HH:mm:ss to yyyy-MM-dd HH:mm:ss

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13680:
URL: https://github.com/apache/flink/pull/13680#issuecomment-711592132


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c4b66492f144a96a1ea793149162b2ef29441f8f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7832",
       "triggerID" : "c4b66492f144a96a1ea793149162b2ef29441f8f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9085414f0bcc7644d623260bdf50758046f95fd",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7887",
       "triggerID" : "f9085414f0bcc7644d623260bdf50758046f95fd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f9085414f0bcc7644d623260bdf50758046f95fd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7887) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org