You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/12/04 09:02:28 UTC

[GitHub] [skywalking-banyandb] WuChuSheng1 opened a new pull request, #224: Add UI for creating and editing tagfamilies and tags. Change some UI styles.

WuChuSheng1 opened a new pull request, #224:
URL: https://github.com/apache/skywalking-banyandb/pull/224

   This PR is mainly for add UI for creating and editing tagfamilies and tags, and to change some UI styles.
   
   **1. add UI for creating and editing tagfamilies and tags.**
   - The original 'new resources' UI:
   
   ![image](https://user-images.githubusercontent.com/107111186/205481904-adc479f8-a527-4ecb-a079-b34deb2af85b.png)
   
     - The old UI does not provide the function of adding and editing tagfamilies and tags,This is not good for the user experience.So I added a UI for this, which provides new and editing functions.
     - First, you can right-click the group and click 'new resources' to enter the dialog box of adding' resources':
   
   ![image](https://user-images.githubusercontent.com/107111186/205482013-a110583f-e5f8-4257-af1f-3f6d889bf890.png)
   ![image](https://user-images.githubusercontent.com/107111186/205482032-b05ad046-e37b-427e-92b2-83eee10a7be0.png)
   
     - Obviously, it provides add, delete, edit and batch delete functions.
     - You can click the 'Add the tagfamilies' button to enter the dialog box for adding' tagfamilies':
   
   ![image](https://user-images.githubusercontent.com/107111186/205482111-2c11ec67-7e10-4d9f-8243-9e86c7dfd758.png)
   It provides add, delete, edit and batch delete functions too.
   
   **Tips:
   It is worth noting that the UI is not connected to the background interface temporarily, but it does not affect the original new 'resources' function. I need to know whether the newly added 'resources' interface provides the newly added tagfamily function, and what is its data structure? Maybe you can help me?**
   
   -  change some UI styles:
     - The old right click menu:
   
   ![image](https://user-images.githubusercontent.com/107111186/205482262-4f6367c4-6ea7-445f-92ec-5b60b8a59da1.png)
   
     - The new right click menu:
   
   ![image](https://user-images.githubusercontent.com/107111186/205482328-388d8e9f-888b-4eab-8bfa-4b1a71585bb1.png)
   
     - The old dialog:
   
   ![image](https://user-images.githubusercontent.com/107111186/205482300-39d0cad7-bf1d-47c8-b9b9-feb7a89f3517.png)
   ![image](https://user-images.githubusercontent.com/107111186/205482308-497a0834-b8b7-475d-9e73-ee69a1ff6704.png)
   
     - The new dialog:
   
   ![image](https://user-images.githubusercontent.com/107111186/205482346-d1c5017a-7282-4b83-a24f-3bba14ff28ed.png)
   ![image](https://user-images.githubusercontent.com/107111186/205482353-e105d9e4-2813-4dcb-8162-773fc8f156ae.png)
   ![image](https://user-images.githubusercontent.com/107111186/205482361-3461fb1a-016d-4168-a402-54ffd76c189a.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] hanahmily merged pull request #224: Add UI for creating and editing tagfamilies and tags. Change some UI styles.

Posted by GitBox <gi...@apache.org>.
hanahmily merged PR #224:
URL: https://github.com/apache/skywalking-banyandb/pull/224


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] hanahmily commented on pull request #224: Add UI for creating and editing tagfamilies and tags. Change some UI styles.

Posted by GitBox <gi...@apache.org>.
hanahmily commented on PR #224:
URL: https://github.com/apache/skywalking-banyandb/pull/224#issuecomment-1340404123

   @WuChuSheng1 
   >  need to know whether the newly added 'resources' interface provides the newly added tagfamily function, and what is its data structure?
   
   The API keeps as before and doesn't provide a separate tag family CRUD operations.
   
   As I mentioned, the "Resource" is a representation notion for UI. APIs only contain Stream and Measure, there is no "Resource" object in the API's specification.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #224: Add UI for creating and editing tagfamilies and tags. Change some UI styles.

Posted by GitBox <gi...@apache.org>.
hanahmily commented on code in PR #224:
URL: https://github.com/apache/skywalking-banyandb/pull/224#discussion_r1041784616


##########
ui/src/components/Database/Aside/components/DialogResources/TagDialog.vue:
##########
@@ -0,0 +1,168 @@
+<!--
+  ~ Licensed to Apache Software Foundation (ASF) under one or more contributor
+  ~ license agreements. See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright
+  ~ ownership. Apache Software Foundation (ASF) licenses this file to you under
+  ~ the Apache License, Version 2.0 (the "License"); you may
+  ~ not use this file except in compliance with the License.
+  ~ You may obtain a copy of the License at
+  ~
+  ~     http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing,
+  ~ software distributed under the License is distributed on an
+  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  ~ KIND, either express or implied.  See the License for the
+  ~ specific language governing permissions and limitations
+  ~ under the License.
+-->
+
+<script setup>
+import { watch, ref, reactive } from 'vue'
+const rule = {
+    tagFamily: [
+        {
+            required: true, message: 'Please enter the tagFamily name', trigger: 'blur'
+        }
+    ]
+}
+const props = defineProps({
+    visible: {
+        type: Boolean,
+        default: false,
+        required: true
+    },
+    operation: {
+        type: String,
+        default: 'Add',
+        required: true
+    },
+    type: {
+        type: String,
+        default: 'Tag',
+        required: true
+    },
+    group: {
+        type: String,
+        required: true
+    },
+    name: {
+        type: String,
+        required: true
+    }
+})
+
+let data = reactive({
+    dialogVisible: false,
+    form: {
+        metadata: {
+            group: '',
+            name: '',
+            tagFamily: ''
+        }
+    }
+})
+let rules = rule
+let tags = [{
+    name: 'start_time',
+    type: 'TAG_TYPE_INT',
+    indexedOnly: false
+}]
+const ruleForm = ref()
+const emit = defineEmits(['confirm', 'cancel'])
+
+watch(() => props.visible, () => {
+    data.dialogVisible = props.visible
+})
+watch(() => props.group, () => {
+    data.form.metadata.group = props.group
+})
+
+function confirmForm() {
+    ruleForm.value.validate((valid) => {
+        if (valid) {
+            emit('confirm', data.form)

Review Comment:
   Could you add validation to check the tag's name is unique in all tag families? And the tag family's name can not be duplicated as well. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] WuChuSheng1 commented on a diff in pull request #224: Add UI for creating and editing tagfamilies and tags. Change some UI styles.

Posted by GitBox <gi...@apache.org>.
WuChuSheng1 commented on code in PR #224:
URL: https://github.com/apache/skywalking-banyandb/pull/224#discussion_r1045177580


##########
ui/src/components/Database/Aside/components/DialogResources/TagDialog.vue:
##########
@@ -0,0 +1,168 @@
+<!--
+  ~ Licensed to Apache Software Foundation (ASF) under one or more contributor
+  ~ license agreements. See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright
+  ~ ownership. Apache Software Foundation (ASF) licenses this file to you under
+  ~ the Apache License, Version 2.0 (the "License"); you may
+  ~ not use this file except in compliance with the License.
+  ~ You may obtain a copy of the License at
+  ~
+  ~     http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing,
+  ~ software distributed under the License is distributed on an
+  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  ~ KIND, either express or implied.  See the License for the
+  ~ specific language governing permissions and limitations
+  ~ under the License.
+-->
+
+<script setup>
+import { watch, ref, reactive } from 'vue'
+const rule = {
+    tagFamily: [
+        {
+            required: true, message: 'Please enter the tagFamily name', trigger: 'blur'
+        }
+    ]
+}
+const props = defineProps({
+    visible: {
+        type: Boolean,
+        default: false,
+        required: true
+    },
+    operation: {
+        type: String,
+        default: 'Add',
+        required: true
+    },
+    type: {
+        type: String,
+        default: 'Tag',
+        required: true
+    },
+    group: {
+        type: String,
+        required: true
+    },
+    name: {
+        type: String,
+        required: true
+    }
+})
+
+let data = reactive({
+    dialogVisible: false,
+    form: {
+        metadata: {
+            group: '',
+            name: '',
+            tagFamily: ''
+        }
+    }
+})
+let rules = rule
+let tags = [{
+    name: 'start_time',
+    type: 'TAG_TYPE_INT',
+    indexedOnly: false
+}]
+const ruleForm = ref()
+const emit = defineEmits(['confirm', 'cancel'])
+
+watch(() => props.visible, () => {
+    data.dialogVisible = props.visible
+})
+watch(() => props.group, () => {
+    data.form.metadata.group = props.group
+})
+
+function confirmForm() {
+    ruleForm.value.validate((valid) => {
+        if (valid) {
+            emit('confirm', data.form)

Review Comment:
   of course



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] codecov-commenter commented on pull request #224: Add UI for creating and editing tagfamilies and tags. Change some UI styles.

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #224:
URL: https://github.com/apache/skywalking-banyandb/pull/224#issuecomment-1336355815

   # [Codecov](https://codecov.io/gh/apache/skywalking-banyandb/pull/224?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#224](https://codecov.io/gh/apache/skywalking-banyandb/pull/224?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (34f4f01) into [main](https://codecov.io/gh/apache/skywalking-banyandb/commit/38ccc66c3396bf7cf3c716f9a4ce4eacfc41c825?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (38ccc66) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@           Coverage Diff           @@
   ##             main     #224   +/-   ##
   =======================================
     Coverage   43.22%   43.22%           
   =======================================
     Files          87       87           
     Lines        8949     8949           
   =======================================
     Hits         3868     3868           
     Misses       4709     4709           
     Partials      372      372           
   ```
   
   
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org