You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/02/26 11:58:40 UTC
[GitHub] [incubator-inlong] shink opened a new pull request #2758: [INLONG-2753][Feature][CI]: Add support for pushing docker images when building them
shink opened a new pull request #2758:
URL: https://github.com/apache/incubator-inlong/pull/2758
building them
fix: #2753
### Motivation
Add support for pushing the latest docker images when building them.
### Modifications
- `.github/workflows/ci_build_docker.yml`
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink commented on pull request #2758: [INLONG-2753][CI] Add support for pushing docker images when building them
Posted by GitBox <gi...@apache.org>.
shink commented on pull request #2758:
URL: https://github.com/apache/incubator-inlong/pull/2758#issuecomment-1053382842
> @dockerzhang Images are only published when changes are committed to `apache/incubator-inlong`, not if the developer commits changes to their own repository or create a PR.
@dockerzhang As I said, when the developer commit changes to their own repository or create a PR, the images should not be published. The images will be published when the changes are committed to the only one repository - `apache/incubator-inlong`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink commented on a change in pull request #2758: [INLONG-2753][Feature][CI]: Add support for pushing docker images when building them
Posted by GitBox <gi...@apache.org>.
shink commented on a change in pull request #2758:
URL: https://github.com/apache/incubator-inlong/pull/2758#discussion_r815381723
##########
File path: .github/workflows/ci_build_docker.yml
##########
@@ -50,3 +55,11 @@ jobs:
run: mvn --batch-mode --update-snapshots -e -V clean package -DskipTests -Pdocker
env:
CI: false
+
+ - name: Push docker image to Docker Hub
+ if: ${{ success() && github.event_name == 'push' && github.repository == 'apache/incubator-inlong' }}
+ run: sh docker/publish.sh
+ env:
+ DOCKER_USER: ${{ secrets.DOCKER_USER }}
+ DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
+ DOCKER_REGISTRY: 'hub.docker.com'
Review comment:
OK, I will remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a change in pull request #2758: [INLONG-2753][Feature][CI]: Add support for pushing docker images when building them
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on a change in pull request #2758:
URL: https://github.com/apache/incubator-inlong/pull/2758#discussion_r815381224
##########
File path: .github/workflows/ci_build_docker.yml
##########
@@ -37,6 +37,11 @@ jobs:
java-version: 8
distribution: adopt
+ - name: Set up Python
+ uses: actions/setup-python@v2
+ with:
+ python-version: 3.7
Review comment:
I have tested `2.7.5`, you can test the `docker/get-project-version.py` using `3.7`.
##########
File path: .github/workflows/ci_build_docker.yml
##########
@@ -50,3 +55,11 @@ jobs:
run: mvn --batch-mode --update-snapshots -e -V clean package -DskipTests -Pdocker
env:
CI: false
+
+ - name: Push docker image to Docker Hub
+ if: ${{ success() && github.event_name == 'push' && github.repository == 'apache/incubator-inlong' }}
+ run: sh docker/publish.sh
+ env:
+ DOCKER_USER: ${{ secrets.DOCKER_USER }}
+ DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
+ DOCKER_REGISTRY: 'hub.docker.com'
Review comment:
Does the `DOCKER_REGISTRY` is needless, the default registry is `hub.docker.com`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink commented on pull request #2758: [INLONG-2753][Feature][CI]: Add support for pushing docker images when building them
Posted by GitBox <gi...@apache.org>.
shink commented on pull request #2758:
URL: https://github.com/apache/incubator-inlong/pull/2758#issuecomment-1053045683
@dockerzhang OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink edited a comment on pull request #2758: [INLONG-2753][CI] Add support for pushing docker images when building them
Posted by GitBox <gi...@apache.org>.
shink edited a comment on pull request #2758:
URL: https://github.com/apache/incubator-inlong/pull/2758#issuecomment-1053382842
> @dockerzhang Images are only published when changes are committed to `apache/incubator-inlong`, not if the developer commits changes to their own repository or create a PR.
@dockerzhang As I said, when the developer commits changes to their own repository or creates a PR, the images should not be published. The images will be published when the changes are committed to the only one repository - `apache/incubator-inlong`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink edited a comment on pull request #2758: [INLONG-2753][CI] Add support for pushing docker images when building them
Posted by GitBox <gi...@apache.org>.
shink edited a comment on pull request #2758:
URL: https://github.com/apache/incubator-inlong/pull/2758#issuecomment-1053382842
> @dockerzhang Images are only published when changes are committed to `apache/incubator-inlong`, not if the developer commits changes to their own repository or create a PR.
@dockerzhang As I said, when the developer who forked this repository commits changes to their own repository or creates a PR, the images should not be published. The images will be published when the changes are committed to the only one repository - `apache/incubator-inlong`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink edited a comment on pull request #2758: [INLONG-2753][CI] Add support for pushing docker images when building them
Posted by GitBox <gi...@apache.org>.
shink edited a comment on pull request #2758:
URL: https://github.com/apache/incubator-inlong/pull/2758#issuecomment-1053382842
> @dockerzhang Images are only published when changes are committed to `apache/incubator-inlong`, not if the developer commits changes to their own repository or create a PR.
@dockerzhang As I said, when the developer commits changes to their own repository or create a PR, the images should not be published. The images will be published when the changes are committed to the only one repository - `apache/incubator-inlong`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink commented on a change in pull request #2758: [INLONG-2753][Feature][CI]: Add support for pushing docker images when building them
Posted by GitBox <gi...@apache.org>.
shink commented on a change in pull request #2758:
URL: https://github.com/apache/incubator-inlong/pull/2758#discussion_r815327414
##########
File path: .github/workflows/ci_build_docker.yml
##########
@@ -37,6 +37,11 @@ jobs:
java-version: 8
distribution: adopt
+ - name: Set up Python
+ uses: actions/setup-python@v2
+ with:
+ python-version: 3.7
Review comment:
@dockerzhang Is the version of python correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #2758: [INLONG-2753][CI] Add support for pushing docker images when building them
Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #2758:
URL: https://github.com/apache/incubator-inlong/pull/2758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink commented on a change in pull request #2758: [INLONG-2753][Feature][CI]: Add support for pushing docker images when building them
Posted by GitBox <gi...@apache.org>.
shink commented on a change in pull request #2758:
URL: https://github.com/apache/incubator-inlong/pull/2758#discussion_r815381693
##########
File path: .github/workflows/ci_build_docker.yml
##########
@@ -37,6 +37,11 @@ jobs:
java-version: 8
distribution: adopt
+ - name: Set up Python
+ uses: actions/setup-python@v2
+ with:
+ python-version: 3.7
Review comment:
I have tested with `3.7.11`, and it worked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink commented on pull request #2758: [INLONG-2753][CI] Add support for pushing docker images when building them
Posted by GitBox <gi...@apache.org>.
shink commented on pull request #2758:
URL: https://github.com/apache/incubator-inlong/pull/2758#issuecomment-1053537183
An error occurred while publishing docker images. I have opened another issue #2772 and will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink edited a comment on pull request #2758: [INLONG-2753][Feature][CI]: Add support for pushing docker images when building them
Posted by GitBox <gi...@apache.org>.
shink edited a comment on pull request #2758:
URL: https://github.com/apache/incubator-inlong/pull/2758#issuecomment-1053041352
@dockerzhang Images are only published when changes are committed to `apache/incubator-inlong`, not if the developer commits changes to their own repository or create a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink commented on pull request #2758: [INLONG-2753][Feature][CI]: Add support for pushing docker images when building them
Posted by GitBox <gi...@apache.org>.
shink commented on pull request #2758:
URL: https://github.com/apache/incubator-inlong/pull/2758#issuecomment-1053041352
@dockerzhang Images are only published when changes are committed to `apache/incubator-inlong`, not if developer commit changes to their own repository or create a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on pull request #2758: [INLONG-2753][Feature][CI]: Add support for pushing docker images when building them
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #2758:
URL: https://github.com/apache/incubator-inlong/pull/2758#issuecomment-1053031644
you can check the `https://registry.hub.docker.com/r/inlong/dataproxy` image later after the workflow action is finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on pull request #2758: [INLONG-2753][Feature][CI]: Add support for pushing docker images when building them
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #2758:
URL: https://github.com/apache/incubator-inlong/pull/2758#issuecomment-1053044682
I mean you can check after workflows are completed about this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on pull request #2758: [INLONG-2753][CI] Add support for pushing docker images when building them
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #2758:
URL: https://github.com/apache/incubator-inlong/pull/2758#issuecomment-1053350282
the `push image` step is skipped?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org