You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/22 13:07:32 UTC

[GitHub] [superset] dpgaspar edited a comment on pull request #12680: feat: dashboard access roles

dpgaspar edited a comment on pull request #12680:
URL: https://github.com/apache/superset/pull/12680#issuecomment-765383546


   I like this approach, IMO we should move to include database, datasets and charts to this pattern also. I personally would like to deprecate string based permissions constructed based on the dataset.name and dataset.id for example.
   
   ![Blank diagram (6)](https://user-images.githubusercontent.com/4025227/105494222-6302e400-5cb2-11eb-8f0d-6a609d73cc6c.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org