[GitHub] [dolphinscheduler] kezhenxu94 commented on a change in pull request #8999: [python] Separate py from main dist and auto add gpg sign

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #8999:
URL: https://github.com/apache/dolphinscheduler/pull/8999#discussion_r830461762



##########
File path: dolphinscheduler-python/pom.xml
##########
@@ -153,14 +153,48 @@
                                     <goal>exec</goal>
                                 </goals>
                                 <configuration>
-                                    <executable>python3</executable>
+                                    <executable>python</executable>
                                     <workingDirectory>${project.basedir}/pydolphinscheduler</workingDirectory>
                                     <arguments>
                                         <argument>-m</argument>
                                         <argument>build</argument>
                                     </arguments>
                                 </configuration>
                             </execution>
+                            <execution>
+                                <id>sign-source</id>
+                                <phase>prepare-package</phase>
+                                <goals>
+                                    <goal>exec</goal>
+                                </goals>
+                                <configuration>
+                                    <skip>${python.sign.skip}</skip>

Review comment:
       What about setting this property to true in profile `release` so that the gpg signature of Python tar is also generated along with the java's?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org